Attachment 176865 Details for Bug 331870

[patch] kdebase3 patch

lockprocess.cc.patch (text/plain), 1.27 KB, created by Lubos Lunak on 2007-10-08 17:32:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lubos Lunak

Created: 2007-10-08 17:32:18 UTC

Size: 1.27 KB

patch

obsolete

>------------------------------------------------------------------------
>r717643 | lunakl | 2007-09-27 11:17:29 +0200 (Ät, 27 zÃ¡Å 2007) | 5 lines
>
>Fix race condition reported by Danny Baumann <dannybaumann@web.de> - when
>creating a new X window for the screensaver, it is temporarily mapped
>while not being override_redirect, causing race conditions.
>
>
>------------------------------------------------------------------------
>Index: lockprocess.cc
>===================================================================
>--- kdesktop/lock/lockprocess.cc	(revision 717642)
>+++ kdesktop/lock/lockprocess.cc	(revision 717643)
>@@ -417,7 +417,7 @@
> {
>     Visual* visual = CopyFromParent;
>     XSetWindowAttributes attrs;
>-    int flags = 0;
>+    int flags = CWOverrideRedirect;
> #ifdef HAVE_GLXCHOOSEVISUAL
>     if( mOpenGLVisual )
>     {
>@@ -461,6 +461,9 @@
>         }
>     }
> #endif
>+
>+    attrs.override_redirect = 1;
>+    hide();
>     Window w = XCreateWindow( x11Display(), RootWindow( x11Display(), x11Screen()),
>         x(), y(), width(), height(), 0, x11Depth(), InputOutput, visual, flags, &attrs );
>     create( w );
>@@ -485,7 +488,6 @@
> 
>     setCursor( blankCursor );
>     setGeometry(0, 0, mRootWidth, mRootHeight);
>-    hide();
> 
>     kdDebug(1204) << "Saver window Id: " << winId() << endl;
> }

Actions: View | Diff

Attachments on bug 331870: 176865