Attachment 197515 Details for Bug 364365

[patch] possible fix for detection of not partitioned fat medias

fixup_partcheck.patch (text/plain), 1.60 KB, created by Frank Seidel on 2008-02-27 21:07:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Frank Seidel

Created: 2008-02-27 21:07:25 UTC

Size: 1.60 KB

patch

obsolete

>From: Frank Seidel <fseidel@suse.de>
>Subject: detect fat media without partition table correctly
>Patch-mainline: no
>References: 364365
>
>Most fat formatted media without partition table contains
>zeros in the boot indication and the other tested bytes
>and so falls through the checks in msdos_partition, leading
>it to return with 1 (all is fine).
>But some (e.g. WinXP formatted) fat fomatted medias don't
>use boot_ind and so the check fails and causes a
>"unkown partition table" warning eventhough there is none
>and everything would be fine.
>This additional check directly verifies if there is a
>fat formatted medium without partition table.
>
>Signed-off-by: Frank Seidel <fseidel@suse.de>
>---
> fs/partitions/msdos.c |    9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>--- a/fs/partitions/msdos.c
>+++ b/fs/partitions/msdos.c
>@@ -18,7 +18,7 @@
>  *
>  *  Re-organised Feb 1998 Russell King
>  */
>-
>+#include <linux/msdos_fs.h>
> 
> #include "check.h"
> #include "msdos.h"
>@@ -419,6 +419,7 @@ int msdos_partition(struct parsed_partit
> 	Sector sect;
> 	unsigned char *data;
> 	struct partition *p;
>+	struct fat_boot_sector *fb;
> 	int slot;
> 
> 	data = read_dev_sector(bdev, 0, &sect);
>@@ -441,6 +442,12 @@ int msdos_partition(struct parsed_partit
> 	 * partition table. Reject this in case the boot indicator
> 	 * is not 0 or 0x80.
> 	 */
>+	fb = (struct fat_boot_sector *) data;
>+	if (fb->reserved && fb->fats && FAT_VALID_MEDIA(fb->media)) {
>+		printk("\n");
>+		put_dev_sector(sect);
>+		return 1;
>+	}
> 	p = (struct partition *) (data + 0x1be);
> 	for (slot = 1; slot <= 4; slot++, p++) {
> 		if (p->boot_ind != 0 && p->boot_ind != 0x80) {

Actions: View | Diff

Attachments on bug 364365: 197515 | 198218