Attachment 202834 Details for Bug 369024

[patch] commit a50f7951a31d3b976e829250853f89c9d2da32c0

nfs-fix-oops-in-nfs_access_cache_shrinker (text/plain), 982 bytes, created by Sven Dietrich on 2008-03-19 03:57:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sven Dietrich

Created: 2008-03-19 03:57:34 UTC

Size: 982 bytes

patch

obsolete

>commit a50f7951a31d3b976e829250853f89c9d2da32c0
>Author: Trond Myklebust <Trond.Myklebust@netapp.com>
>Date:   Tue Jun 5 19:23:43 2007 -0400
>
>    NFS: Fix an Oops in the nfs_access_cache_shrinker()
>    
>    The nfs_access_cache_shrinker may race with nfs_access_zap_cache().
>    
>    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
>
>diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
>index 0f41678..322141f 100644
>--- a/fs/nfs/dir.c
>+++ b/fs/nfs/dir.c
>@@ -1743,8 +1743,8 @@ int nfs_access_cache_shrinker(int nr_to_scan, gfp_t gfp_mask)
> 	struct nfs_inode *nfsi;
> 	struct nfs_access_entry *cache;
> 
>-	spin_lock(&nfs_access_lru_lock);
> restart:
>+	spin_lock(&nfs_access_lru_lock);
> 	list_for_each_entry(nfsi, &nfs_access_lru_list, access_cache_inode_lru) {
> 		struct inode *inode;
> 
>@@ -1769,6 +1769,7 @@ remove_lru_entry:
> 			clear_bit(NFS_INO_ACL_LRU_SET, &nfsi->flags);
> 		}
> 		spin_unlock(&inode->i_lock);
>+		spin_unlock(&nfs_access_lru_lock);
> 		iput(inode);
> 		goto restart;
> 	}

Actions: View | Diff

Attachments on bug 369024: 200131 | 202834 | 202835