Attachment 203584 Details for Bug 230478

[patch] Reload the tile tables on demand, not at startup

0003-Reload-the-tile-tables-when-they-are-needed-not-at.patch (text/plain), 3.67 KB, created by Federico Mena Quintero on 2008-03-24 17:27:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Federico Mena Quintero

Created: 2008-03-24 17:27:19 UTC

Size: 3.67 KB

patch

obsolete

>From 0d107d4aaa2eeabc95406bd41299bf9098a15eaa Mon Sep 17 00:00:00 2001
>From: Federico Mena Quintero <federico@gnu.org>
>Date: Wed, 19 Dec 2007 17:06:51 -0600
>Subject: [PATCH] Reload the tile tables when they are needed, not at startup
> 2007-12-19  Federico Mena Quintero  <federico@novell.com>
>
>	* main-menu/src/tile-table.c (tile_table_new): Don't reload the
>	table here.  This prevents unnecessary loading at startup...
>
>	* main-menu/src/main-menu-ui.c (select_page): ... but rather
>	reload them here when selecting a page.
>	(main_menu_ui_new): Reload the sys_table here, at startup.
>	(apply_lockdown_settings): And don't reload all the tables here.
>
>Signed-off-by: Federico Mena Quintero <federico@gnu.org>
>---
> ChangeLog                    |   10 ++++++++++
> main-menu/src/main-menu-ui.c |   27 +++++++++++++++++++++------
> main-menu/src/tile-table.c   |    2 --
> 3 files changed, 31 insertions(+), 8 deletions(-)
>
>diff --git a/ChangeLog b/ChangeLog
>index 7d41188..1add36f 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,5 +1,15 @@
> 2007-12-19  Federico Mena Quintero  <federico@novell.com>
> 
>+	* main-menu/src/tile-table.c (tile_table_new): Don't reload the
>+	table here.  This prevents unnecessary loading at startup...
>+
>+	* main-menu/src/main-menu-ui.c (select_page): ... but rather
>+	reload them here when selecting a page.
>+	(main_menu_ui_new): Reload the sys_table here, at startup.
>+	(apply_lockdown_settings): And don't reload all the tables here.
>+
>+2007-12-19  Federico Mena Quintero  <federico@novell.com>
>+
> 	* main-menu/src/main-menu-ui.c (select_page): Take in a
> 	"set_page_selector_button" argument, to decide whether we set the
> 	correct button here as well.  Also, set the notebook page.  This
>diff --git a/main-menu/src/main-menu-ui.c b/main-menu/src/main-menu-ui.c
>index 487400f..c4aac8b 100644
>--- a/main-menu/src/main-menu-ui.c
>+++ b/main-menu/src/main-menu-ui.c
>@@ -294,6 +294,8 @@ main_menu_ui_new (PanelApplet *applet)
> 
> 	bind_beagle_search_key  (this);
> 	update_limits           (this);
>+
>+	tile_table_reload (priv->sys_table);
> 	select_page             (this, TRUE);
> 	apply_lockdown_settings (this);
> 
>@@ -1128,6 +1130,25 @@ select_page (MainMenuUI *this, gboolean set_page_selector_button)
> 	}
> 
> 	gtk_notebook_set_current_page (priv->file_section, priv->notebook_page_ids [curr_page]);
>+
>+	switch (curr_page) {
>+	case APPS_PAGE:
>+		tile_table_reload (priv->file_tables[USER_APPS_TABLE]);
>+		tile_table_reload (priv->file_tables[RCNT_APPS_TABLE]);
>+		break;
>+
>+	case DOCS_PAGE:
>+		tile_table_reload (priv->file_tables[USER_DOCS_TABLE]);
>+		tile_table_reload (priv->file_tables[RCNT_DOCS_TABLE]);
>+		break;
>+
>+	case DIRS_PAGE:
>+		tile_table_reload (priv->file_tables[USER_DIRS_TABLE]);
>+		break;
>+
>+	default:
>+		g_assert_not_reached ();
>+	}
> }
> 
> static void
>@@ -1514,12 +1535,6 @@ apply_lockdown_settings (MainMenuUI *this)
> 	for (i = 0; i < 5; ++i)
> 		set_table_section_visible (this, priv->file_tables [i]);
> 
>-	tile_table_reload (priv->sys_table);
>-	tile_table_reload (priv->file_tables [USER_APPS_TABLE]);
>-	tile_table_reload (priv->file_tables [RCNT_APPS_TABLE]);
>-	tile_table_reload (priv->file_tables [USER_DOCS_TABLE]);
>-	tile_table_reload (priv->file_tables [USER_DIRS_TABLE]);
>-
> 	update_limits (this);
> }
> 
>diff --git a/main-menu/src/tile-table.c b/main-menu/src/tile-table.c
>index 6cbc858..93819bd 100644
>--- a/main-menu/src/tile-table.c
>+++ b/main-menu/src/tile-table.c
>@@ -101,8 +101,6 @@ tile_table_new (BookmarkAgent *agent, gint limit, gint n_cols,
> 	priv->create_item_func = uti_func;
> 	priv->item_func_data   = data_uti;
> 
>-	tile_table_reload (TILE_TABLE (this));
>-
> 	g_signal_connect (
> 		G_OBJECT (priv->agent), "notify::" BOOKMARK_AGENT_ITEMS_PROP,
> 		G_CALLBACK (agent_notify_cb), this);
>-- 
>1.5.3.4
>

Actions: View | Diff

Attachments on bug 230478: 203582 | 203583 | 203584 | 203585 | 203586 | 206381