Bugzilla – Attachment 203585 Details for
Bug 230478
main-menu: pointless thumbnailing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Forgot Password
[patch]
Ensure the page selector buttons are visible
0004-Make-sure-the-page-selector-buttons-are-visible-at-s.patch (text/plain), 3.62 KB, created by
Federico Mena Quintero
on 2008-03-24 17:27:44 UTC
(
hide
)
Description:
Ensure the page selector buttons are visible
Filename:
MIME Type:
Creator:
Federico Mena Quintero
Created:
2008-03-24 17:27:44 UTC
Size:
3.62 KB
patch
obsolete
>From 045ffe9f555f1510ac99b34ee127f950e28443f9 Mon Sep 17 00:00:00 2001 >From: Federico Mena Quintero <federico@gnu.org> >Date: Wed, 19 Dec 2007 18:55:43 -0600 >Subject: [PATCH] Make sure the page selector buttons are visible at startup > 2007-12-19 Federico Mena Quintero <federico@novell.com> > > * main-menu/src/tile-table.c (tile_table_new): Don't reload the > table here. This prevents unnecessary loading at startup... > > * main-menu/src/main-menu-ui.c (select_page): ... but rather > reload them here when selecting a page. > (main_menu_ui_new): Reload the sys_table here, at startup. > (apply_lockdown_settings): And don't reload all the tables here. > (set_table_section_visible): Don't take into account the number of > tiles within a table; only consider whether that type of tile is > allowed to be visible. Make the code shorter. > >Signed-off-by: Federico Mena Quintero <federico@gnu.org> >--- > ChangeLog | 3 +++ > main-menu/src/main-menu-ui.c | 33 +++++++++++---------------------- > 2 files changed, 14 insertions(+), 22 deletions(-) > >diff --git a/ChangeLog b/ChangeLog >index 1add36f..8f0859d 100644 >--- a/ChangeLog >+++ b/ChangeLog >@@ -7,6 +7,9 @@ > reload them here when selecting a page. > (main_menu_ui_new): Reload the sys_table here, at startup. > (apply_lockdown_settings): And don't reload all the tables here. >+ (set_table_section_visible): Don't take into account the number of >+ tiles within a table; only consider whether that type of tile is >+ allowed to be visible. Make the code shorter. > > 2007-12-19 Federico Mena Quintero <federico@novell.com> > >diff --git a/main-menu/src/main-menu-ui.c b/main-menu/src/main-menu-ui.c >index c4aac8b..a95a960 100644 >--- a/main-menu/src/main-menu-ui.c >+++ b/main-menu/src/main-menu-ui.c >@@ -1298,36 +1298,25 @@ set_table_section_visible (MainMenuUI *this, TileTable *table) > > gint table_id; > GList *tiles; >+ gboolean visible; > > > table_id = GPOINTER_TO_INT (g_object_get_data (G_OBJECT (table), "table-id")); > g_object_get (G_OBJECT (table), TILE_TABLE_TILES_PROP, & tiles, NULL); > >- if (priv->allowable_types [table_id] && g_list_length (tiles) > 0) >- gtk_widget_show (priv->table_sections [table_id]); >- else >- gtk_widget_hide (priv->table_sections [table_id]); >+ visible = priv->allowable_types [table_id]; >+ g_object_set (priv->table_sections [table_id], "visible", visible, NULL); > >- if ( >- GTK_WIDGET_VISIBLE (priv->table_sections [USER_APPS_TABLE]) || >- GTK_WIDGET_VISIBLE (priv->table_sections [RCNT_APPS_TABLE]) >- ) >- gtk_widget_show (priv->page_selectors [APPS_PAGE]); >- else >- gtk_widget_hide (priv->page_selectors [APPS_PAGE]); >+ visible = (GTK_WIDGET_VISIBLE (priv->table_sections [USER_APPS_TABLE]) >+ || GTK_WIDGET_VISIBLE (priv->table_sections [RCNT_APPS_TABLE])); >+ g_object_set (priv->page_selectors [APPS_PAGE], "visible", visible, NULL); > >- if ( >- GTK_WIDGET_VISIBLE (priv->table_sections [USER_DOCS_TABLE]) || >- GTK_WIDGET_VISIBLE (priv->table_sections [RCNT_DOCS_TABLE]) >- ) >- gtk_widget_show (priv->page_selectors [DOCS_PAGE]); >- else >- gtk_widget_hide (priv->page_selectors [DOCS_PAGE]); >+ visible = (GTK_WIDGET_VISIBLE (priv->table_sections [USER_DOCS_TABLE]) || >+ GTK_WIDGET_VISIBLE (priv->table_sections [RCNT_DOCS_TABLE])); >+ g_object_set (priv->page_selectors [DOCS_PAGE], "visible", visible, NULL); > >- if (GTK_WIDGET_VISIBLE (priv->table_sections [USER_DIRS_TABLE])) >- gtk_widget_show (priv->page_selectors [DIRS_PAGE]); >- else >- gtk_widget_hide (priv->page_selectors [DIRS_PAGE]); >+ visible = GTK_WIDGET_VISIBLE (priv->table_sections [USER_DIRS_TABLE]); >+ g_object_set (priv->page_selectors [DIRS_PAGE], "visible", visible, NULL); > } > > static gchar ** >-- >1.5.3.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
Actions:
View
|
Diff
Attachments on
bug 230478
:
203582
|
203583
|
203584
|
203585
|
203586
|
206381