Attachment 219883 Details for Bug 355225

[patch] gtk2-bnc355225-filechooser-tab-completion-crash.diff

gtk2-bnc355225-filechooser-tab-completion-crash.diff (text/plain), 993 bytes, created by Federico Mena Quintero on 2008-06-03 18:12:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Federico Mena Quintero

Created: 2008-06-03 18:12:10 UTC

Size: 993 bytes

patch

obsolete

>2008-06-03  Federico Mena Quintero  <federico@novell.com>
>
>	* gtk/gtkfilechooserentry.c (install_completion_feedback_timer):
>	If the user presses Tab while the completion feedback window is
>	active, then we'll assert.  Remove the assertion and just re-set
>	the timer.  Fixes https://bugzilla.novell.com/show_bug.cgi?id=355225
>
>diff --git a/gtk/gtkfilechooserentry.c b/gtk/gtkfilechooserentry.c
>index aef6d31..a98041a 100644
>--- a/gtk/gtkfilechooserentry.c
>+++ b/gtk/gtkfilechooserentry.c
>@@ -939,7 +939,8 @@ completion_feedback_timeout_cb (gpointer data)
> static void
> install_completion_feedback_timer (GtkFileChooserEntry *chooser_entry)
> {
>-  g_assert (chooser_entry->completion_feedback_timeout_id == 0);
>+  if (chooser_entry->completion_feedback_timeout_id != 0)
>+    g_source_remove (chooser_entry->completion_feedback_timeout_id);
> 
>   chooser_entry->completion_feedback_timeout_id = gdk_threads_add_timeout (COMPLETION_FEEDBACK_TIMEOUT_MS,
> 									   completion_feedback_timeout_cb,

Actions: View | Diff

Attachments on bug 355225: 219883