Bugzilla – Attachment 230317 Details for
Bug 402256
main-menu process high cpu usage
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Forgot Password
[patch]
gnome-main-menu-bnc402256-no-thumbnails.diff
gnome-main-menu-bnc402256-no-thumbnails.diff (text/plain), 2.16 KB, created by
Federico Mena Quintero
on 2008-07-28 17:56:25 UTC
(
hide
)
Description:
gnome-main-menu-bnc402256-no-thumbnails.diff
Filename:
MIME Type:
Creator:
Federico Mena Quintero
Created:
2008-07-28 17:56:25 UTC
Size:
2.16 KB
patch
obsolete
>commit 72415c0f3b282da188b244d4fc5113f2620ed129 >Author: Federico Mena Quintero <federico@gnu.org> >Date: Mon Jul 28 12:27:40 2008 -0500 > > bnc402256 - Don't generate thumbnails synchronously; let Nautilus handle that, as it has the async logic already > 2008-07-28 Federico Mena Quintero <federico@novell.com> > > https://bugzilla.novell.com/show_bug.cgi?id=402256 - Main-menu has > high CPU usage on NIS/NFS home directories. > > * document-tile.c (load_image): Don't do thumbnailing ourselves, > as we don't have the threading logic to do it in the background. > Instead, let Nautilus handle thumbnailing by itself. > > Signed-off-by: Federico Mena Quintero <federico@gnu.org> > >diff --git a/libslab/document-tile.c b/libslab/document-tile.c >index 4587d7f..696ef95 100644 >--- a/libslab/document-tile.c >+++ b/libslab/document-tile.c >@@ -424,9 +424,6 @@ load_image (DocumentTile *tile) > { > DocumentTilePrivate *priv = DOCUMENT_TILE_GET_PRIVATE (tile); > >- GdkPixbuf *thumb; >- gchar *thumb_path; >- > gchar *icon_id = NULL; > gboolean free_icon_id = TRUE; > GnomeThumbnailFactory *thumbnail_factory; >@@ -445,32 +442,7 @@ load_image (DocumentTile *tile) > > thumbnail_factory = libslab_thumbnail_factory_get (); > >- thumb_path = gnome_thumbnail_factory_lookup (thumbnail_factory, TILE (tile)->uri, priv->modified); >- >- if (!thumb_path) { >- if ( >- gnome_thumbnail_factory_can_thumbnail ( >- thumbnail_factory, TILE (tile)->uri, priv->mime_type, priv->modified) >- ) { >- thumb = gnome_thumbnail_factory_generate_thumbnail ( >- thumbnail_factory, TILE (tile)->uri, priv->mime_type); >- >- if (thumb) { >- gnome_thumbnail_factory_save_thumbnail ( >- thumbnail_factory, thumb, TILE (tile)->uri, priv->modified); >- >- icon_id = gnome_thumbnail_factory_lookup ( >- thumbnail_factory, TILE (tile)->uri, priv->modified); >- >- g_object_unref (thumb); >- } >- else >- gnome_thumbnail_factory_create_failed_thumbnail ( >- thumbnail_factory, TILE (tile)->uri, priv->modified); >- } >- } >- else >- icon_id = thumb_path; >+ icon_id = gnome_thumbnail_factory_lookup (thumbnail_factory, TILE (tile)->uri, priv->modified); > > if (! icon_id) > icon_id = gnome_icon_lookup (
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
Actions:
View
|
Diff
Attachments on
bug 402256
:
226200
|
226231
| 230317 |
232385
|
247701
|
248215
|
248228
|
250505