Attachment 244844 Details for Bug 434259

[patch] update suggestion

quotes.diff (text/plain), 3.09 KB, created by Markus Elfring on 2008-10-10 11:03:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Markus Elfring

Created: 2008-10-10 11:03:50 UTC

Size: 3.09 KB

patch

obsolete

>Index: qt-pkg/src/YQPkgTechnicalDetailsView.cc
>===================================================================
>--- qt-pkg/src/YQPkgTechnicalDetailsView.cc	(Revision 52031)
>+++ qt-pkg/src/YQPkgTechnicalDetailsView.cc	(Arbeitskopie)
>@@ -85,7 +85,7 @@
> QString
> YQPkgTechnicalDetailsView::authorsListCell( ZyppPkg pkg ) const
> {
>-    QString html = "<td align=top>";
>+    QString html = "<td align='top'>";
>     QString line;
>     list<string> authors = pkg->authors();
>     list<string>::const_iterator it = authors.begin();
>Index: qt-pkg/src/YQPkgSelDescriptionView.cc
>===================================================================
>--- qt-pkg/src/YQPkgSelDescriptionView.cc	(Revision 52031)
>+++ qt-pkg/src/YQPkgSelDescriptionView.cc	(Arbeitskopie)
>@@ -132,10 +132,10 @@
>     }
> 
> 
>-    QString html = "<table width=100%";
>+    QString html = "<table width='100%'";
> 
>     if ( ! YQUI::ui()->usingVisionImpairedPalette() )
>-	html += " bgcolor=#C8C8F8";	// or #E0E0F8 (very light blueish grey)
>+	html += " bgcolor='#C8C8F8'";	// or #E0E0F8 (very light blueish grey)
> 
>     html += "><tr><td>"
> 	+ ( useBigFont ? QString( "<h2>" ) : QString( "<b>" ) )
>@@ -146,9 +146,9 @@
> 
>     if ( ! icon.isEmpty() )
>     {
>-	html = QString( "<table width=100%><tr>" )
>+	html = QString( "<table width='100%'><tr>" )
> 	    + "<td><img src=\"" + icon + "\"></td>"
>-	    + "<td width=100%>" + html + "</td>"
>+	    + "<td width='100%'>" + html + "</td>"
> 	    + "</tr></table>";
>     }
> 
>Index: qt-pkg/src/YQPackageSelectorHelp.cc
>===================================================================
>--- qt-pkg/src/YQPackageSelectorHelp.cc	(Revision 52031)
>+++ qt-pkg/src/YQPackageSelectorHelp.cc	(Arbeitskopie)
>@@ -136,7 +136,7 @@
>     QString html = YQPkgTextDialog::htmlHeading( _( "Symbols Overview" ) );
> 
>     html += "<br>";
>-    html += "<table border=1>";
>+    html += "<table border='1'>";
> 
>     html += symHelp( "noinst.xpm",
> 		     // Translators: Package status short (!) description
>@@ -224,7 +224,7 @@
> 			    const QString & explanation		)
> {
>     QString imgPath = HELPIMAGEDIR;
>-    QString html = "<tr valign=top>";
>+    QString html = "<tr valign='top'>";
>     html += "<td><img src=\"" + imgPath + "/" + imgFileName + "\"></td>"
> 	+ "<td>" + summary 	+ "</td>"
> 	+ "<td>" + explanation 	+ "</td>"
>@@ -317,9 +317,9 @@
> 			    const QString & summary,
> 			    const QString & explanation		)
> {
>-    QString html = "<tr valign=top>";
>+    QString html = "<tr valign='top'>";
>     html +=
>-	"<td><table bgcolor=#E0E0E0><tr><td align=center><b>"
>+	"<td><table bgcolor='#E0E0E0'><tr><td align='center'><b>"
> 	+ key
> 	+ "</b></td></tr></table></td>"
> 	+ "<td>" + summary 	+ "</td>"
>Index: qt-pkg/src/YQPkgChangeLogView.cc
>===================================================================
>--- qt-pkg/src/YQPkgChangeLogView.cc	(Revision 52031)
>+++ qt-pkg/src/YQPkgChangeLogView.cc	(Arbeitskopie)
>@@ -87,7 +87,7 @@
> 	html += row(
> 		    cell( (*it).date()   ) +
> 		    cell( (*it).author() ) +
>-		    "<td valign=top>" + changes + "</td>" // cell() calls htmlEscape() !
>+		    "<td valign='top'>" + changes + "</td>" // cell() calls htmlEscape() !
> 		    );
>     }
>

Actions: View | Diff

Attachments on bug 434259: 244844