Attachment 413892 Details for Bug 652562

[patch] Proposed fix for both bugs.

desktop-splash-with-screen-24bpp.diff (text/plain), 1.12 KB, created by Petr Mladek on 2011-02-14 16:38:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Petr Mladek

Created: 2011-02-14 16:38:10 UTC

Size: 1.12 KB

patch

obsolete

>--- desktop/unx/source/splashx.c.old	2010-11-11 16:30:07.000000000 +0100
>+++ desktop/unx/source/splashx.c	2011-02-11 21:46:52.000000000 +0100
>@@ -333,6 +333,7 @@ static void create_pixmap()
>             int x, y; \
>             for ( y = 0; y < height; ++y ) \
>             { \
>+                out = data + y * bytes_per_line; \
>                 unsigned long red_delta = 0, green_delta = 0, blue_delta = 0; \
>                 color_t *in = (color_t *)bitmap_rows[y]; \
>                 for ( x = 0; x < width; ++x, ++in  ) \
>@@ -376,7 +376,7 @@ static void create_pixmap()
>         {
>             if ( machine_byte_order == byte_order && byte_order == LSBFirst )
>                 COPY_IN_OUT( 3, *( (color_t *)out ) = *( (color_t *)( &pixel ) ); out += 3; )
>-            if ( machine_byte_order == byte_order && byte_order == MSBFirst )
>+            else if ( machine_byte_order == byte_order && byte_order == MSBFirst )
>                 COPY_IN_OUT( 3, uint32_t tmp = pixel;
>                              *( (uint8_t *)out     ) = *( (uint8_t *)(&tmp) + 1 );
>                              *( (uint8_t *)out + 1 ) = *( (uint8_t *)(&tmp) + 2 );

Actions: View | Diff

Attachments on bug 652562: 399346 | 399361 | 413688 | 413892