Attachment 415180 Details for Bug 465039

[patch] tasklet debug patch

tasklet-debug.patch (text/plain), 1.81 KB, created by Jiri Slaby on 2011-02-20 16:45:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jiri Slaby

Created: 2011-02-20 16:45:53 UTC

Size: 1.81 KB

patch

obsolete

>---
> include/linux/interrupt.h |    6 ++++--
> kernel/softirq.c          |   13 +++++++++++++
> 2 files changed, 17 insertions(+), 2 deletions(-)
>
>--- a/include/linux/interrupt.h
>+++ b/include/linux/interrupt.h
>@@ -470,13 +470,15 @@ struct tasklet_struct
> 	atomic_t count;
> 	void (*func)(unsigned long);
> 	unsigned long data;
>+	unsigned long checkp;
>+	unsigned int usage;
> };
> 
> #define DECLARE_TASKLET(name, func, data) \
>-struct tasklet_struct name = { NULL, 0, ATOMIC_INIT(0), func, data }
>+struct tasklet_struct name = { NULL, 0, ATOMIC_INIT(0), func, data, INITIAL_JIFFIES }
> 
> #define DECLARE_TASKLET_DISABLED(name, func, data) \
>-struct tasklet_struct name = { NULL, 0, ATOMIC_INIT(1), func, data }
>+struct tasklet_struct name = { NULL, 0, ATOMIC_INIT(1), func, data, INITIAL_JIFFIES }
> 
> 
> enum
>--- a/kernel/softirq.c
>+++ b/kernel/softirq.c
>@@ -389,6 +389,9 @@ void __tasklet_schedule(struct tasklet_s
> {
> 	unsigned long flags;
> 
>+	if (t->checkp == INITIAL_JIFFIES)
>+		t->checkp = jiffies + HZ;
>+
> 	local_irq_save(flags);
> 	t->next = NULL;
> 	*__get_cpu_var(tasklet_vec).tail = t;
>@@ -443,6 +446,14 @@ static void tasklet_action(struct softir
> 			if (!atomic_read(&t->count)) {
> 				if (!test_and_clear_bit(TASKLET_STATE_SCHED, &t->state))
> 					BUG();
>+				t->usage++;
>+				if (time_before(t->checkp, jiffies)) {
>+					printk("%s: %ps %pf scheduled too many times: %u\n", __func__, t, t->func, t->usage);
>+					if (t->usage > 100)
>+						printk("%s: %ps %pf scheduled too many times: %u\n", __func__, t, t->func, t->usage);
>+					t->usage = 0;
>+					t->checkp = jiffies + HZ;
>+				}
> 				t->func(t->data);
> 				tasklet_unlock(t);
> 				continue;
>@@ -503,6 +514,8 @@ void tasklet_init(struct tasklet_struct
> 	atomic_set(&t->count, 0);
> 	t->func = func;
> 	t->data = data;
>+	t->usage = 0;
>+	t->checkp = jiffies + HZ;
> }
> 
> EXPORT_SYMBOL(tasklet_init);

Actions: View | Diff

Attachments on bug 465039: 264360 | 279389 | 279390 | 279486 | 279654 | 279655 | 287170 | 323402 | 324468 | 324507 | 324847 | 328648 | 409384 | 415179 | 415180