Attachment 499996 Details for Bug 733148

[patch] brcmsmac: Document firmware dependencies

brcmsmac-firmware (text/plain), 986 bytes, created by Jeff Mahoney on 2012-07-25 21:10:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeff Mahoney

Created: 2012-07-25 21:10:25 UTC

Size: 986 bytes

patch

obsolete

>From: Jeff Mahoney <jeffm@suse.com>
>Subject: brcmsmac: document firmware dependencies
>References: bnc#733148
>
> The brcmsmac driver requests firmware but doesn't document the
> dependency. This means that software that analyzes the modules to
> determine if firmware is needed won't detect it.
>
> Specifically, (at least) openSUSE won't install the kernel-firmware
> package if no hardware requires it.
>
> This patch adds the MODULE_FIRMWARE directives.
>
>Signed-off-by: Jeff Mahoney <jeffm@suse.com>
>---
> drivers/staging/brcm80211/brcmsmac/mac80211_if.c |    4 ++++
> 1 file changed, 4 insertions(+)
>
>--- a/drivers/staging/brcm80211/brcmsmac/mac80211_if.c
>+++ b/drivers/staging/brcm80211/brcmsmac/mac80211_if.c
>@@ -1737,6 +1737,10 @@ char *brcms_firmwares[MAX_FW_IMAGES] = {
> 	NULL
> };
> 
>+/* This needs to be adjusted when brcms_firmware changes */
>+MODULE_FIRMWARE("brcm/bcm43xx-0.fw");
>+MODULE_FIRMWARE("brcm/bcm43xx_hdr-0.fw");
>+
> /*
>  * precondition: perimeter lock has been acquired
>  */

Actions: View | Diff

Attachments on bug 733148: 487016 | 498062 | 499996