Attachment 510912 Details for Bug 716652

[patch] ifup-wireless: do not fail on unsupported power options

0001-ifup-wireless-do-not-fail-on-unsupported-power-optio.patch (text/plain), 2.28 KB, created by Marius Tomaschewski on 2012-10-25 16:33:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marius Tomaschewski

Created: 2012-10-25 16:33:11 UTC

Size: 2.28 KB

patch

obsolete

>From 9bb6f64db086f0364f153ba142b5f3be67ce4baf Mon Sep 17 00:00:00 2001
>From: Marius Tomaschewski <mt@suse.com>
>Date: Thu, 25 Oct 2012 16:30:51 +0200
>Subject: [PATCH] ifup-wireless: do not fail on unsupported power options
>
>The power management support differs from driver to driver;
>complain, but do not forward errors (cause ifup failures)
>when the specified power operation is not supported ...
>---
> scripts/ifup-wireless |   14 ++++++++------
> 1 Datei geÃ¤ndert, 8 Zeilen hinzugefÃ¼gt(+), 6 Zeilen entfernt(-)
>
>diff --git a/scripts/ifup-wireless b/scripts/ifup-wireless
>index e0b7caa..4ad4f61 100755
>--- a/scripts/ifup-wireless
>+++ b/scripts/ifup-wireless
>@@ -783,20 +783,22 @@ case $ACTION in
>             ""|none) ;;
>             yes)    run_iw_tool config power period 2
>                     if [ $RETVAL -eq 250 ]; then
>-                        # The power operation is invalid or unsupported.
>+                        # The power operations may be not supported by the
>+                        # driver and not all driver support all modes ...
>                         iwconfig $INTERFACE power off 2> /dev/null
>-                        # If the power operation is unsupported, ignore the error.
>-                        [ $? -eq 250 ] && RETVAL=$R_SUCCESS
>+                        # Error were logged/displayed ... don't fail here.
>+                        RETVAL=$R_SUCCESS
>                     fi ;;
>             no|off) run_iw_tool config power off
>                     # If the power operation is unsupported, ignore the error.
>                     [ $RETVAL -eq 250 ] && RETVAL=$R_SUCCESS ;;
>             *)      run_iw_tool config power $WIRELESS_POWER
>                     if [ $RETVAL -eq 250 ]; then
>-                        # The power operation is invalid or unsupported.
>+                        # The power operations may be not supported by the
>+                        # driver and not all driver support all modes ...
>                         iwconfig $INTERFACE power off 2> /dev/null
>-                        # If the power operation is unsupported, ignore the error.
>-                        [ $? -eq 250 ] && RETVAL=$R_SUCCESS
>+                        # Error were logged/displayed ... don't fail here.
>+                        RETVAL=$R_SUCCESS
>                     fi ;;
>         esac
> 
>-- 
>1.7.10.4
>

Actions: View | Diff

Attachments on bug 716652: 452882 | 510912