Attachment 727600 Details for Bug 1039348

[patch] fix candidate v4

0001-mm-memory.c-convert-to-DEFINE_DEBUGFS_ATTRIBUTE.patch (text/plain), 1.46 KB, created by Michal Hocko on 2017-06-03 08:06:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michal Hocko

Created: 2017-06-03 08:06:29 UTC

Size: 1.46 KB

patch

obsolete

>From f9f6524aeb33f4fe06df84e23f593df71ca4a465 Mon Sep 17 00:00:00 2001
>From: Yevgen Pronenko <y.pronenko@gmail.com>
>Date: Wed, 31 May 2017 10:41:10 +0200
>Subject: [PATCH 1/2] mm/memory.c: convert to DEFINE_DEBUGFS_ATTRIBUTE
>
>The preferred strategy to define debugfs attributes is to use the
>DEFINE_DEBUGFS_ATTRIBUTE() macro and to use debugfs_create_file_unsafe().
>
>Link: http://lkml.kernel.org/r/20170528145948.32127-1-y.pronenko@gmail.com
>Signed-off-by: Yevgen Pronenko <y.pronenko@gmail.com>
>Cc: "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
>Cc: Jan Kara <jack@suse.cz>
>Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>---
> mm/memory.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/mm/memory.c b/mm/memory.c
>index bc3864d133c4..5082ac0f5025 100644
>--- a/mm/memory.c
>+++ b/mm/memory.c
>@@ -3300,14 +3300,14 @@ static int fault_around_bytes_set(void *data, u64 val)
> 		fault_around_bytes = PAGE_SIZE; /* rounddown_pow_of_two(0) is undefined */
> 	return 0;
> }
>-DEFINE_SIMPLE_ATTRIBUTE(fault_around_bytes_fops,
>+DEFINE_DEBUGFS_ATTRIBUTE(fault_around_bytes_fops,
> 		fault_around_bytes_get, fault_around_bytes_set, "%llu\n");
> 
> static int __init fault_around_debugfs(void)
> {
> 	void *ret;
> 
>-	ret = debugfs_create_file("fault_around_bytes", 0644, NULL, NULL,
>+	ret = debugfs_create_file_unsafe("fault_around_bytes", 0644, NULL, NULL,
> 			&fault_around_bytes_fops);
> 	if (!ret)
> 		pr_warn("Failed to create fault_around_bytes in debugfs");
>-- 
>2.11.0
>

Actions: View | Diff

Attachments on bug 1039348: 725338 | 727600 | 727601 | 727627 | 727764 | 727765 | 729853