Attachment 727601 Details for Bug 1039348

[patch] follow up fix

0002-amd-xgbe-use-PAGE_ALLOC_COSTLY_ORDER-in-xgbe_map_rx_.patch (text/plain), 1.71 KB, created by Michal Hocko on 2017-06-03 08:06:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michal Hocko

Created: 2017-06-03 08:06:52 UTC

Size: 1.71 KB

patch

obsolete

>From 30ec83a5809c41edbefa3d5eb4c6fc521f4aedae Mon Sep 17 00:00:00 2001
>From: Michal Hocko <mhocko@suse.com>
>Date: Fri, 2 Jun 2017 16:34:28 +0200
>Subject: [PATCH 2/2] amd-xgbe: use PAGE_ALLOC_COSTLY_ORDER in
> xgbe_map_rx_buffer
>
>xgbe_map_rx_buffer is rather confused about what PAGE_ALLOC_COSTLY_ORDER
>means. It uses PAGE_ALLOC_COSTLY_ORDER-1 assuming that
>PAGE_ALLOC_COSTLY_ORDER is the first costly order which is not the case
>actually because orders larger than that are costly. And even that
>applies only to sleeping allocations which is not the case here. We
>simply do not perform any costly operations like reclaim or compaction
>for those. Simplify the code by dropping the order calculation and use
>PAGE_ALLOC_COSTLY_ORDER directly.
>
>Signed-off-by: Michal Hocko <mhocko@suse.com>
>---
> drivers/net/ethernet/amd/xgbe/xgbe-desc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-desc.c b/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
>index b3bc87fe3764..0a98c369df20 100644
>--- a/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
>+++ b/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
>@@ -324,7 +324,7 @@ static int xgbe_map_rx_buffer(struct xgbe_prv_data *pdata,
> 			      struct xgbe_ring *ring,
> 			      struct xgbe_ring_data *rdata)
> {
>-	int order, ret;
>+	int ret;
> 
> 	if (!ring->rx_hdr_pa.pages) {
> 		ret = xgbe_alloc_pages(pdata, &ring->rx_hdr_pa, GFP_ATOMIC, 0);
>@@ -333,9 +333,8 @@ static int xgbe_map_rx_buffer(struct xgbe_prv_data *pdata,
> 	}
> 
> 	if (!ring->rx_buf_pa.pages) {
>-		order = max_t(int, PAGE_ALLOC_COSTLY_ORDER - 1, 0);
> 		ret = xgbe_alloc_pages(pdata, &ring->rx_buf_pa, GFP_ATOMIC,
>-				       order);
>+				       PAGE_ALLOC_COSTLY_ORDER);
> 		if (ret)
> 			return ret;
> 	}
>-- 
>2.11.0
>

Actions: View | Diff

Attachments on bug 1039348: 725338 | 727600 | 727601 | 727627 | 727764 | 727765 | 729853