Attachment 728063 Details for Bug 1043231

[patch] 0005-extcon-arizona-Remove-the-usage-of-extcon_update_sta.patch

0005-extcon-arizona-Remove-the-usage-of-extcon_update_sta.patch (text/plain), 1.67 KB, created by Matwey Kornilov on 2017-06-07 19:35:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matwey Kornilov

Created: 2017-06-07 19:35:30 UTC

Size: 1.67 KB

patch

obsolete

>From 4bd926f34c5c66c393dbbc0672537d8ed4157cf3 Mon Sep 17 00:00:00 2001
>From: Chanwoo Choi <cw00.choi@samsung.com>
>Date: Fri, 1 Jul 2016 02:36:49 +0900
>Subject: [PATCH 05/19] extcon: arizona: Remove the usage of
> extcon_update_state()
>
>This patch remvoes the usage of extcon_update_state() because
>the extcon_update_state() use directly the bit masking calculation
>to change the state of external connector without the unique id of
>external connector. It makes the code diffcult to read it.
>So, this patch uses the extcon_set_cable_state_() instead.
>
>Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
>Git-commit: 5475e6317525b37241766c2e87731fd152e1150b
>Patch-mainline: v4.9-rc1
>Signed-off-by: Matwey V. Kornilov <matwey.kornilov@gmail.com>
>---
> drivers/extcon/extcon-arizona.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
>index e4890dd4fefd..1a50610c9b32 100644
>--- a/drivers/extcon/extcon-arizona.c
>+++ b/drivers/extcon/extcon-arizona.c
>@@ -1149,10 +1149,13 @@ static irqreturn_t arizona_jackdet(int irq, void *data)
> 					 info->micd_ranges[i].key, 0);
> 		input_sync(info->input);
> 
>-		ret = extcon_update_state(info->edev, 0xffffffff, 0);
>-		if (ret != 0)
>-			dev_err(arizona->dev, "Removal report failed: %d\n",
>-				ret);
>+		for (i = 0; i < ARRAY_SIZE(arizona_cable) - 1; i++) {
>+			ret = extcon_set_cable_state_(info->edev,
>+					arizona_cable[i], false);
>+			if (ret != 0)
>+				dev_err(arizona->dev,
>+					"Removal report failed: %d\n", ret);
>+		}
> 
> 		regmap_update_bits(arizona->regmap,
> 				   ARIZONA_JACK_DETECT_DEBOUNCE,
>-- 
>2.12.0
>

Actions: View | Diff

Attachments on bug 1043231: 728059 | 728060 | 728061 | 728062 | 728063 | 728064 | 728065 | 728066 | 728067 | 728068 | 728069 | 728070 | 728071 | 728072 | 728073 | 728074 | 728075 | 728076 | 728077 | 728521 | 728695 | 728770