Bugzilla – Attachment 810465 Details for
Bug 1141444
clementine: a memory hog
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Forgot Password
[patch]
delete the allocated mem v2
delete.patch (text/plain), 929 bytes, created by
Jiri Slaby
on 2019-07-15 12:25:11 UTC
(
hide
)
Description:
delete the allocated mem v2
Filename:
MIME Type:
Creator:
Jiri Slaby
Created:
2019-07-15 12:25:11 UTC
Size:
929 bytes
patch
obsolete
>--- > ext/libclementine-tagreader/tagreader.cpp | 6 ++++++ > ext/libclementine-tagreader/tagreader.h | 1 + > 2 files changed, 7 insertions(+) > >--- a/ext/libclementine-tagreader/tagreader.cpp >+++ b/ext/libclementine-tagreader/tagreader.cpp >@@ -125,6 +125,12 @@ TagReader::TagReader() > network_(new QNetworkAccessManager), > kEmbeddedCover("(embedded)") {} > >+TagReader::~TagReader() >+{ >+ delete factory_; >+ delete network_; >+} >+ > void TagReader::ReadFile(const QString& filename, > pb::tagreader::SongMetadata* song) const { > const QByteArray url(QUrl::fromLocalFile(filename).toEncoded()); >--- a/ext/libclementine-tagreader/tagreader.h >+++ b/ext/libclementine-tagreader/tagreader.h >@@ -50,6 +50,7 @@ class FileRefFactory; > class TagReader { > public: > TagReader(); >+ ~TagReader(); > > void ReadFile(const QString& filename, > pb::tagreader::SongMetadata* song) const;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=810465">View the attachment on a separate page</a>.</b>
Actions:
View
|
Diff
Attachments on
bug 1141444
:
810426
|
810435
|
810464
|
810465
|
810466
|
810549
|
811247
|
811251