Attachment 844708 Details for Bug 1180344

[patch] Tentative fix patch

0001-iwlwifi-dbg-Don-t-touch-the-tlv-data.patch (text/plain), 1.49 KB, created by Takashi Iwai on 2020-12-27 11:53:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Takashi Iwai

Created: 2020-12-27 11:53:25 UTC

Size: 1.49 KB

patch

obsolete

>From: Takashi Iwai <tiwai@suse.de>
>Subject: [PATCH] iwlwifi: dbg: Don't touch the tlv data
>
>The commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device
>memory") added a termination of name string just to be sure, and this
>seems causing a regression, a GPF triggered at firmware loading.
>Basically we shouldn't modify the firmware data that may be provided
>as read-only.
>
>This patch drops the code that caused the regression and keep the tlv
>data as is.
>
>Fixes: ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory")
>BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1180344
>BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210733
>Signed-off-by: Takashi Iwai <tiwai@suse.de>
>
>---
> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 7 -------
> 1 file changed, 7 deletions(-)
>
>diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
>index a654147d3cd6..a80a35a7740f 100644
>--- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
>+++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
>@@ -180,13 +180,6 @@ static int iwl_dbg_tlv_alloc_region(struct iwl_trans *trans,
> 	if (le32_to_cpu(tlv->length) < sizeof(*reg))
> 		return -EINVAL;
> 
>-	/* For safe using a string from FW make sure we have a
>-	 * null terminator
>-	 */
>-	reg->name[IWL_FW_INI_MAX_NAME - 1] = 0;
>-
>-	IWL_DEBUG_FW(trans, "WRT: parsing region: %s\n", reg->name);
>-
> 	if (id >= IWL_FW_INI_MAX_REGION_ID) {
> 		IWL_ERR(trans, "WRT: Invalid region id %u\n", id);
> 		return -EINVAL;
>-- 
>2.26.2
>

Actions: View | Diff

Attachments on bug 1180344: 844693 | 844694 | 844695 | 844696 | 844697 | 844708 | 844714