|
Bugzilla – Full Text Bug Listing |
| Summary: | Insufficient disk space does not prevent upgrade | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE Distribution | Reporter: | Karl Cheng <qantas94heavy> |
| Component: | YaST2 | Assignee: | YaST Team <yast-internal> |
| Status: | RESOLVED FIXED | QA Contact: | Jiri Srain <jsrain> |
| Severity: | Normal | ||
| Priority: | P3 - Medium | CC: | ancor, jreidinger |
| Version: | Leap 42.2 | ||
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | Other | ||
| URL: | https://trello.com/c/Npbs5g2F | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Attachments: | Warning only displayed on the upgrade summary | ||
Aren't package conflicts handled with extra dialog? Maybe that mechanism could be reused here. First of all, it's "just" a warning because we can't really tell how much space will be needed at the end. Especially with e.g., btrfs in the play. As this is just a warning, it's not marked as "error" and thus not a hard stop. If we were 100% sure, we would make it and "error" obviously. Maybe ... we could implement something that would ask user to confirm that he/she is aware of those warnings before proceeding with the upgrade or installation and that it might fail. The installer itself is just a generic framework and software, bootloader, etc. are just plug-ins. To implement something additionally, we would need to do it in a generic way. Side note: Although, package conflicts dialog is something completely different, we could implement that in a similar way. With package conflicts we are really sure that the problem is there. On the other hand the space calculation is just an estimation, you can never know the exact needed space in advance (it depends on FS, packages might create or remove big files in %post, etc...), more over I remember some bug where a package (grub?) was reported to be 2GB in size (in repository metadata) but in reality it was just few megabytes. Therefore we should not block the installation/upgrade in this situation. My advise is: read the proposal carefully, if you see any red text think what can happen if you continue... The proposal currently supports "warning", "error" and "blocker" levels. Adding a new level "almost-blocker" does not sound good to me. At some point the user would still need to decide whether to continue or not. And that would require an extra popup which I do not like because it's not really needed. Either you start the installation or not. Reopened after some discussion, we should ask the user to explicitly confirm the "error" level messages and allow continuing only if the user confirms that. Added to YaST team Scrum backlog for it to be prioritized in relation to other tasks. Implemented for TW. |
Created attachment 696461 [details] Warning only displayed on the upgrade summary Although the upgrade warns about insufficient space available on the summary page, if the user clicks "Update", there is no more warnings specific to that issue, just two license notices and a general "ready to install" page. If the upgrade is actually attempted, the upgrade fails (predictably) with "insufficient space" errors and aborting the installation at this point results in a broken system. Is this intended behaviour or not?