Bug 1005652

Summary: Installation fails after selecting online repositories when using Traditional Chinese
Product: [openSUSE] openSUSE Distribution Reporter: Karl Cheng <qantas94heavy>
Component: InstallationAssignee: Karl Eichwalder <ke>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P2 - High CC: ancor, dimstar, mlin, sbrabec
Version: Leap 42.2   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 1004064    
Attachments: YaST installation logs
Initial error message displayed

Description Karl Cheng 2016-10-19 14:54:08 UTC
Created attachment 698113 [details]
YaST installation logs

Language selected: Traditional Chinese
Keyboard setting: English (US)

If the following language settings are used and the equivalent of "Add online repositories before installation" is selected, the installation fails after the "List of Online Repositories" screen.

This also occurs on upgrade where repositories are removed and new ones added.

I have not tried selecting any further languages other than English and Traditional Chinese, nor any keyboard settings other than English (US).
Comment 1 Karl Cheng 2016-10-19 14:55:29 UTC
Created attachment 698114 [details]
Initial error message displayed
Comment 2 Ancor Gonzalez Sosa 2016-10-19 16:00:47 UTC
Looks like a markup error in the translated string. I will check
Comment 3 Ancor Gonzalez Sosa 2016-10-20 15:09:33 UTC
The problem is in the Chinese translation of the string

"If you want to print this EULA, you can find it\non the first media in the file %s"

The Chinese version contains both a "%1" (which is not present in the English version) and a "%s".

Reassigning to Translators' coordinator.
Comment 4 Ludwig Nussel 2016-10-24 16:20:39 UTC
It's here:
https://l10n.opensuse.org/translate/yast-packager/master/zh_TW/?checksum=d946c416bc47f83ea565fbd2ca366122

I wonder why weblate doesn't detect this format string error?
Comment 7 Stanislav Brabec 2016-10-26 17:44:59 UTC
I am not sure, whether Weblate knows %1. The string is not marked as c-source, so maybe it does not parse '%' at all.

Fixed in the source (plus another apparent format issue). It should appear in GitHub in two hours.
Comment 9 Stanislav Brabec 2016-10-26 17:54:41 UTC
If there is any person who can read Traditional Chinese: Please check my fix.


%1 come from the older version (and its source string). It was just overseen on upgrade.

#. TRANSLATORS: addition license information
#. %1 is replaced with the filename
#: src/modules/ProductLicense.rb:383
msgid ""
"If you want to print this EULA, you can find it\n"
"on the first media in the file %1"
msgstr ""
Comment 10 Karl Cheng 2016-10-29 14:28:01 UTC
(In reply to Stanislav Brabec from comment #9)
> If there is any person who can read Traditional Chinese: Please check my fix.
> 
> 
> %1 come from the older version (and its source string). It was just overseen
> on upgrade.
> 
> #. TRANSLATORS: addition license information
> #. %1 is replaced with the filename
> #: src/modules/ProductLicense.rb:383
> msgid ""
> "If you want to print this EULA, you can find it\n"
> "on the first media in the file %1"
> msgstr ""

My Chinese isn't exactly great, but I *think* the %s should be where the %1 used to be.
Comment 11 Stanislav Brabec 2016-11-01 16:52:57 UTC
Karl Cheng: OK, changed to:

如果您想列印這份 EULA,可以在
第一個媒體中的 %s 檔案中找到
Comment 12 Ludwig Nussel 2016-11-07 12:37:40 UTC
I suppose this is fixed now. Please reopen if not.
Comment 13 Karl Eichwalder 2016-12-07 10:32:51 UTC
thanks. I'm going to release it together with bug 1004064 for SLE 12 SP2.  I think the fix is already in Leap.
Comment 14 Swamp Workflow Management 2016-12-30 18:09:18 UTC
SUSE-RU-2016:3306-1: An update that has three recommended fixes can now be installed.

Category: recommended (low)
Bug References: 1004064,1005652,1012545
CVE References: 
Sources used:
SUSE Linux Enterprise Server for Raspberry Pi 12-SP2 (src):    yast2-trans-3.0.0-50.1
SUSE Linux Enterprise Server 12-SP2 (src):    yast2-trans-3.0.0-50.1
SUSE Linux Enterprise Desktop 12-SP2 (src):    yast2-trans-3.0.0-50.1