Bug 1015998

Summary: OpenSuse's Firefox version crashes when "cancel" pressed in "File Upload" dialogue, e.g. TYPO3, BUGZILLA
Product: [openSUSE] openSUSE Distribution Reporter: Michael from Offenbach Germany <michaelof>
Component: FirefoxAssignee: E-mail List <bnc-team-mozilla>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: asn, astieger, fabian, fkrueger, forgotten_yGLSzpoYRq, fvogt, itaranto7, linus.kardell, michaelof, wolfgang, yunhe.guo
Version: Leap 42.2   
Target Milestone: ---   
Hardware: x86-64   
OS: Other   
Whiteboard: kde-integration maint:planned:update
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: Open File dialogue on Leap 42.2
"File Upload" dialogue on Mozilla's version of firefox
"reproduce bug" button - here in Bugzilla :-)
FF 51.0.1 CrashReport
gdb -p $(pidof kmozillahelper) -ex c -ex bt -ex q
gdb /usr/lib64/firefox/firefox -ex r -ex bt -ex q
gdb /usr/lib64/firefox/firefox -ex r -ex bt -ex q

Description Michael from Offenbach Germany 2016-12-16 13:10:27 UTC
I've detected this 100% reproducible crash and reported to bugzilla.mozilla.org, as program affected is Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1322608

But we found out, that this crash ONLY appears when using OpenSuse's packaged Firefox, please look at my comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1322608#c4

OpenSuse's firefox uses/opens a different "File Open" / "Select file" /"Durchsuchen" (German) dialogue than original Mozilla's firefox. 

Seems to be a KDE "Dolphin" dialogue.
Comment 1 Michael from Offenbach Germany 2016-12-16 13:12:07 UTC
Created attachment 706765 [details]
Open File dialogue on Leap 42.2
Comment 2 Michael from Offenbach Germany 2016-12-16 13:13:01 UTC
Created attachment 706766 [details]
"File Upload" dialogue on Mozilla's version of firefox
Comment 3 Michael from Offenbach Germany 2016-12-16 13:18:55 UTC
Created attachment 706767 [details]
"reproduce bug" button - here in Bugzilla :-)
Comment 4 Michael from Offenbach Germany 2016-12-16 13:20:35 UTC
Last Attachement shows how to reproduce bug there in bugzilla.opensuse.org.
- Press Button to open dialogue
- Press Cancel in dialogue
Comment 5 Andreas Stieger 2016-12-16 14:27:59 UTC
Please test with MozillaFirefox 50.1.0-45.1 from the update repository (just released).
Please test with MozillaFirefox 50.1.0-570.1 (or later) from the mozilla:Factory project.
Comment 6 Michael from Offenbach Germany 2016-12-16 15:56:19 UTC
(In reply to Andreas Stieger from comment #5)
> Please test with MozillaFirefox 50.1.0-45.1 from the update repository (just
> released).
> Please test with MozillaFirefox 50.1.0-570.1 (or later) from the
> mozilla:Factory project.

No idea what "update repository" might be, neither http://download.opensuse.org/repositories/openSUSE:/Leap:/42.2:/Update/standard/ nor http://download.opensuse.org/update/leap/42.2/non-oss/ nor http://download.opensuse.org/update/leap/42.2/oss offer "MozillaFirefox 50.1.0-45.1" ??

BUT added http://download.opensuse.org/repositories/mozilla:/Factory/openSUSE_Leap_42.2/ and installed 50.1.0-570.1

RESULT: CRASHES also.
Comment 7 Wolfgang Bauer 2017-02-01 22:57:08 UTC
*** Bug 1023083 has been marked as a duplicate of this bug. ***
Comment 8 Fabian Vogt 2017-02-02 09:03:05 UTC
Please get a backtrace of the crash and try to reproduce the issue with kmozillahelper from mozilla:experimental
Comment 9 Michael from Offenbach Germany 2017-02-02 19:46:19 UTC
Hi Fabian,

of course I would like to help as much as I can to get this issue solved. But I'm not familiar with either "backtrace" or "kmozillahelper from mozilla:experimental". If you advice what and how to do, I certainly will do asap. 

For the original bugzilla.mozilla.org issue (https://bugzilla.mozilla.org/show_bug.cgi?id=1322608) I was asked to provide a "crash report" and was told that Firefox for OpenSuse "does not contain symbols" (https://bugzilla.mozilla.org/show_bug.cgi?id=1322608#c3) and that's why a crash report was not helpful. Also valid here?

Regards,
Michael
Comment 10 Frank Krüger 2017-02-02 20:31:05 UTC
Created attachment 712645 [details]
FF 51.0.1 CrashReport
Comment 11 Frank Krüger 2017-02-02 20:32:38 UTC
I can confirm the crash described here, with openSUSE Leap 42.2, FF 51.0.1-1.1.x86_64, and kmozillahelper-4.9.15-1.1.x86_64. Enclosed you will find the crash report. Hope this helps to solve the issue.
Comment 12 Fabian Vogt 2017-02-02 20:37:28 UTC
(In reply to Michael from Offenbach Germany from comment #9)
> Hi Fabian,
> 
> of course I would like to help as much as I can to get this issue solved.
> But I'm not familiar with either "backtrace" or "kmozillahelper from
> mozilla:experimental". If you advice what and how to do, I certainly will do
> asap. 

Ok, to get a backtrace you'll need to open a terminal window (with two tabs) and run

    gdb /usr/lib64/firefox/firefox -ex r -ex bt -ex q

in one and after firefox is started,

    gdb -p $(pidof kmozillahelper) -ex c -ex bt -ex q

in the other.
After you reproduced the crash, you'll find a backtrace in one of the outputs.
Copy it and paste them into a textfile and attach it here.

To get kmozillahelper from mozilla:experimental, run:

    zypper ar obs://mozilla:experimental/openSUSE_Leap_42.2 m:e
    zypper dup --from m:e
    <test here>
    zypper rr m:e
    zypper in --force mozilla-kde4-integration
Comment 13 Frank Krüger 2017-02-02 21:30:34 UTC
Following your suggestion to get a backtrace of the crash, firefox does not crash but freezes.
Comment 14 Michael from Offenbach Germany 2017-02-02 21:44:00 UTC
Created attachment 712657 [details]
gdb -p $(pidof kmozillahelper) -ex c -ex bt -ex q
Comment 15 Michael from Offenbach Germany 2017-02-02 21:44:32 UTC
Created attachment 712658 [details]
gdb /usr/lib64/firefox/firefox -ex r -ex bt -ex q
Comment 16 Michael from Offenbach Germany 2017-02-02 21:46:26 UTC
(In reply to Frank Kruger from comment #13)
> Following your suggestion to get a backtrace of the crash, firefox does not
> crash but freezes.

Thought at first the same. Freeze / no CPU usage. But then I've seen that one of the gdb sessions detected the crash and was waiting for a confirmation. So no freeze on my side.
Comment 17 Frank Krüger 2017-02-02 22:07:02 UTC
Created attachment 712664 [details]
gdb /usr/lib64/firefox/firefox -ex r -ex bt -ex q

Here we go.
Comment 18 Forgotten User yGLSzpoYRq 2017-02-11 16:29:24 UTC
I've encountered this bug on my Gentoo build of firefox, using the OpenSUSE patchset. Tested, and present, with all versions of kmozillahelper 4.9.9-5.0.0 along with firefox 51.0 ...

To add to this report - the segmentation fault only occurs if the experimental e10 / electrolysis feature is enabled (another user reported this on the kmozillahelper Github page -  I can confirm this). See:
https://github.com/openSUSE/kmozillahelper/issues/8

If e10 support is disabled. The Cancel button - in the kmozillahelper QFileDialog - behaves as expected.
Comment 19 Fabian Vogt 2017-02-11 18:46:11 UTC
This is not a bug inside kmozillahelper, but rather in the integration patch and closely related to bug 1022224.
As it crashes firefox I request a reevaluation of the priority.
Setting to confirmed due to various reports from different sources.
Comment 20 Linus Kardell 2017-03-27 13:16:33 UTC
Since nothing seems to be happening here, and this bug causes lot's of crashes, it would probably be best to remove the patch until someone can get around to fixing it.
Comment 21 Fabian Vogt 2017-03-27 13:21:38 UTC
(In reply to Linus Kardel from comment #20)
> Since nothing seems to be happening here, and this bug causes lot's of
> crashes, it would probably be best to remove the patch until someone can get
> around to fixing it.

Just disable e10s or remove kmozillahelper in the meanwhile.
Comment 22 Linus Kardell 2017-03-27 19:31:01 UTC
(In reply to Fabian Vogt from comment #21)
> (In reply to Linus Kardel from comment #20)
> > Since nothing seems to be happening here, and this bug causes lot's of
> > crashes, it would probably be best to remove the patch until someone can get
> > around to fixing it.
> 
> Just disable e10s or remove kmozillahelper in the meanwhile.

There doesn't seem to be a package called kmozillahelper in Leap. Though there seems to be one in Tumbleweed.
Comment 23 Fabian Vogt 2017-03-27 19:35:07 UTC
(In reply to Linus Kardell from comment #22)
> (In reply to Fabian Vogt from comment #21)
> > (In reply to Linus Kardel from comment #20)
> > > Since nothing seems to be happening here, and this bug causes lot's of
> > > crashes, it would probably be best to remove the patch until someone can get
> > > around to fixing it.
> > 
> > Just disable e10s or remove kmozillahelper in the meanwhile.
> 
> There doesn't seem to be a package called kmozillahelper in Leap. Though
> there seems to be one in Tumbleweed.

Yes, the older KDE4 based package is called mozilla-kde4-integration.
Comment 24 Wolfgang Rosenauer 2017-04-26 12:32:41 UTC
We have a patch which might fix this issue. I will report here the revisions and locations of builds including this for people to verify.
Comment 25 Forgotten User yGLSzpoYRq 2017-04-26 14:29:31 UTC
(In reply to Wolfgang Rosenauer from comment #24)
> We have a patch which might fix this issue. I will report here the revisions
> and locations of builds including this for people to verify.

I'll quite happily test out any patches... 8->
Perhaps the patch could be attached to this bug report as well?
Thanks
Comment 26 Wolfgang Rosenauer 2017-04-26 15:47:56 UTC
Firefox 53 from the mozilla repository has the patch included now starting with version: 53.0-6.1

I'll attach the patch after the first success message ;-)
Comment 27 Wolfgang Rosenauer 2017-04-26 15:49:28 UTC
(In reply to Robert Walker from comment #25)

> I'll quite happily test out any patches... 8->
> Perhaps the patch could be attached to this bug report as well?

The patch is in Firefox btw not in kmozillahelper fwiw.
Comment 28 Frank Krüger 2017-04-28 17:26:41 UTC
Using Firefox-53.0-6.3.x86_64 from the mozilla repo I do not experience the above-mentioned crashes anymore. Thx.
Comment 29 Fabian Vogt 2017-05-08 07:17:17 UTC
Can this fix get submitted to Leap 42.3 as well?
AFAICT it's affected (52.1.0) and the fix isn't in mozilla-kde.patch and there is no SR pending.
Comment 30 Wolfgang Rosenauer 2017-05-08 08:37:09 UTC
It will be summited with next Firefox update.
It's already fixed for 52.1 in the Mozilla repository and therefore will end up in the update package in any case. Submitting a new package out of band I didn't find important enough.
Actually just checked and next planned version arrives mid of June. So I consider submitting a new package inbetween.
Comment 31 Forgotten User yGLSzpoYRq 2017-05-08 22:19:29 UTC
I've tested the updated Mercurial repository (http://www.rosenauer.org/hg/mozilla/) branches with my my Gentoo ebuilds (firefox patched with OpenSUSE patchset). The bug is no longer present... Thanks :-)
Comment 32 Andreas Stieger 2017-05-09 07:47:47 UTC
Processed for maintenance. Test updates will appear first in the repositories below:
http://download.opensuse.org/update/leap/42.1-test/
http://download.opensuse.org/update/leap/42.2-test/
http://download.opensuse.org/repositories/openSUSE:/Maintenance:/6663/
Comment 33 Bernhard Wiedemann 2017-05-09 08:00:51 UTC
This is an autogenerated message for OBS integration:
This bug (1015998) was mentioned in
https://build.opensuse.org/request/show/493640 42.1 / MozillaFirefox
https://build.opensuse.org/request/show/493641 42.2 / MozillaFirefox
https://build.opensuse.org/request/show/493642 Factory / MozillaFirefox
Comment 34 Wolfgang Rosenauer 2017-05-10 13:23:24 UTC
Considering fixed with latest submission. Updates will be available in near future.
Comment 35 Swamp Workflow Management 2017-05-15 16:20:29 UTC
openSUSE-RU-2017:1267-1: An update that has two recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1015998,1026989
CVE References: 
Sources used:
openSUSE Leap 42.2 (src):    MozillaFirefox-52.1.1-57.9.1
openSUSE Leap 42.1 (src):    MozillaFirefox-52.1.1-64.1
Comment 36 Andreas Schneider 2017-05-18 15:14:09 UTC
*** Bug 1039755 has been marked as a duplicate of this bug. ***