Bug 1031315

Summary: k3b fails to build with GCC 7
Product: [openSUSE] openSUSE Tumbleweed Reporter: Martin Liška <martin.liska>
Component: KDE ApplicationsAssignee: E-Mail List <opensuse-kde-bugs>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: fabian, fvogt, lbeltrame
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 1030236    

Description Martin Liška 2017-03-28 11:57:34 UTC
GCC 7 fails due to:

[  135s] /home/abuild/rpmbuild/BUILD/k3b-2.0.3/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp: In member function 'QString K3bFFMpegFile::title() const':
[  135s] /home/abuild/rpmbuild/BUILD/k3b-2.0.3/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:264:23: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
[  135s]      if( ade->value != '\0' )
[  135s]                        ^~~~
[  135s] /home/abuild/rpmbuild/BUILD/k3b-2.0.3/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp: In member function 'QString K3bFFMpegFile::author() const':
[  135s] /home/abuild/rpmbuild/BUILD/k3b-2.0.3/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:277:23: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
[  135s]      if( ade->value != '\0' )
[  135s]                        ^~~~
[  135s] /home/abuild/rpmbuild/BUILD/k3b-2.0.3/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp: In member function 'QString K3bFFMpegFile::comment() const':
[  135s] /home/abuild/rpmbuild/BUILD/k3b-2.0.3/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:290:23: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
[  135s]      if( ade->value != '\0' )
[  135s]                        ^~~~
[  135s] /home/abuild/rpmbuild/BUILD/k3b-2.0.3/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp: In member function 'int K3bFFMpegFile::fillOutputBuffer()':
[  135s] /home/abuild/rpmbuild/BUILD/k3b-2.0.3/plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp:350:21: warning: 'int avcodec_decode_audio4(AVCodecContext*, AVFrame*, int*, const AVPacket*)' is deprecated [-Wdeprecated-declarations]
[  135s]          int len = ::avcodec_decode_audio4(
[  135s]                      ^~~~~~~~~~~~~~~~~~~~~

Can be tested in openSUSE:Factory:Staging:Gcc7 project.
Comment 2 Fabian Vogt 2017-03-28 12:01:07 UTC
This is already fixed upstream and will land in TW with version 17.04.
Comment 3 Martin Liška 2017-03-28 12:18:37 UTC
Good, thanks!