Bug 1031342

Summary:	vinagre fails to build with GCC 7
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Martin Liška <martin.liska>
Component:	GNOME	Assignee:	Dominique Leuenberger <dimstar>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None	CC:	dimstar
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	1030236

Description Martin Liška 2017-03-28 12:36:32 UTC

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:Gcc7/vinagre/standard/x86_64

[   49s] vinagre/vinagre-utils.c:686:2: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]
[   49s]   _tmp12_ = g_strdup_printf (_tmp10_, _tmp11_);
[   49s]   ^~~~~~~
[   49s] vinagre/vinagre-utils.c:717:2: warning: 'gtk_image_new_from_stock' is deprecated: Use 'gtk_image_new_from_icon_name' instead [-Wdeprecated-declarations]
[   49s]   _tmp34_ = (GtkImage*) gtk_image_new_from_stock (GTK_STOCK_DIALOG_AUTHENTICATION, GTK_ICON_SIZE_BUTTON);
[   49s]   ^~~~~~~
[   49s] In file included from /usr/include/gtk-3.0/gtk/gtkentry.h:42:0,
[   49s]                  from /usr/include/gtk-3.0/gtk/gtktreeview.h:29,
[   49s]                  from /usr/include/gtk-3.0/gtk/gtkcombobox.h:27,
[   49s]                  from /usr/include/gtk-3.0/gtk/gtkappchooserbutton.h:29,
[   49s]                  from /usr/include/gtk-3.0/gtk/gtk.h:42,
[   49s]                  from vinagre/vinagre-utils.c:26:
[   49s] /usr/include/gtk-3.0/gtk/gtkimage.h:122:12: note: declared here
[   49s]  GtkWidget* gtk_image_new_from_stock     (const gchar     *stock_id,
[   49s]             ^~~~~~~~~~~~~~~~~~~~~~~~
[   49s] vinagre/vinagre-utils.c:717:2: warning: 'GtkStock' is deprecated [-Wdeprecated-declarations]
[   49s]   _tmp34_ = (GtkImage*) gtk_image_new_from_stock (GTK_STOCK_DIALOG_AUTHENTICATION, GTK_ICON_SIZE_BUTTON);
[   49s]   ^~~~~~~
[   49s] At top level:
[   49s] vinagre/vinagre-utils.c:194:20: warning: 'block2_data_ref' defined but not used [-Wunused-function]
[   49s]  static Block2Data* block2_data_ref (Block2Data* _data2_) {
[   49s]                     ^~~~~~~~~~~~~~~

Can be tested in openSUSE:Factory:Staging:Gcc7 project.

Comment 1 Dominique Leuenberger 2017-05-16 14:16:16 UTC

[   49s] vinagre/vinagre-utils.c:686:2: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]
[   49s]   _tmp12_ = g_strdup_printf (_tmp10_, _tmp11_);

This is actually the only error - the rest are deprecated warnings (not new with gcc7)

In this case it just seems format-nonliteral is newly treated as error - which in case of the vala generated C code is just a but noisy.

I'll create a submission filtering this error away

Comment 2 Dominique Leuenberger 2017-05-17 14:55:33 UTC

Fix has been submitted and staged in :C

Comment 3 Dominique Leuenberger 2017-05-17 14:56:07 UTC

https://build.opensuse.org/request/show/495627