Bug 1032474

Summary:	mozjs17 fails to build with GCC7
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Martin Liška <martin.liska>
Component:	Firefox	Assignee:	E-mail List <bnc-team-mozilla>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None	CC:	wolfgang
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	1030236

Description Martin Liška 2017-04-05 09:20:28 UTC

Can be seen here:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:C/mozjs17/standard/x86_64

[  116s] /home/abuild/rpmbuild/BUILD/mozjs17.0.0/js/src/shell/jsoptparse.cpp: In member function 'js::cli::OptionParser::Result js::cli::OptionParser::extractValue(size_t, char**, size_t*, char**)':
[  116s] /home/abuild/rpmbuild/BUILD/mozjs17.0.0/js/src/shell/jsoptparse.cpp:246:25: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
[  116s]          if (value[0] == '\0')
[  116s]                          ^~~~

Comment 1 Wolfgang Rosenauer 2017-04-05 10:29:56 UTC

We should get rid of unmaintained mozjs17 in TW.
Need to find out which component still uses it and try to move them to a more recent version.

Comment 2 Martin Liška 2017-04-24 13:46:23 UTC

(In reply to Wolfgang Rosenauer from comment #1)
> We should get rid of unmaintained mozjs17 in TW.
> Need to find out which component still uses it and try to move them to a
> more recent version.

Hello. Any update on that? Looks there's just few last packages blocking the Staging:C project which changes default compiler to GCC7.

Comment 3 Martin Liška 2017-04-25 09:55:17 UTC

Ok, fixing the issue is actually very simple. A simple patch from trunk is needed. I'll create SR soon.

Comment 4 Wolfgang Rosenauer 2017-04-25 10:53:15 UTC

Actually I was hoping to create some pressure onto consumers to migrate away from mozjs17 which is horribly outdated and we want to get rid of asap. Fixing it does not help with that :-(

Comment 5 Martin Liška 2017-04-25 10:59:08 UTC

(In reply to Wolfgang Rosenauer from comment #4)
> Actually I was hoping to create some pressure onto consumers to migrate away
> from mozjs17 which is horribly outdated and we want to get rid of asap.
> Fixing it does not help with that :-(

I see, well I'm motivated to have staging C with new GCC ready as soon as possible. That said:

osc whatdependson openSUSE:Factory:Staging:C mozjs17 standard x86_64
mozjs17 :
   colord
   gconf2
   installation-images
   pcsc-lite
   polkit
   polkit-default-privs
   rpmlint-mini
   yast2-country

If at least these packages will be migrated, then it can go in Factory and other people will be forced to fix their packages.

Comment 6 Martin Liška 2017-04-26 12:14:41 UTC

>    polkit

I took a look at polkit package. Problem is that last release was done in Jun 2015 and currently there're various patches that port that to mozjs24, but it's no a trivial set of patches we can backport :/

Comment 7 Martin Liška 2017-04-26 12:15:04 UTC

Fix has landed in Factory, thus closing as fixed.