Bug 1039384

Summary:	mozjs24 fails to build with GCC7
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Dominique Leuenberger <dimstar>
Component:	Firefox	Assignee:	E-mail List <bnc-team-mozilla>
Status:	RESOLVED WONTFIX	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None	CC:	i, martin.liska, wolfgang
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	1030236

Description Dominique Leuenberger 2017-05-16 19:17:51 UTC

Can be seen here:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:C:DVD/mozjs24/standard/x86_64

[  352s] /home/abuild/rpmbuild/BUILD/mozjs-24.2.0/js/src/shell/jsoptparse.cpp:256:25: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
[  352s]          if (value[0] == '\0')
[  352s]                          ^~~~
[  352s] make[2]: *** [../config/rules.mk:1140: jsoptparse.o] Error 1
[  352s] make[2]: *** Waiting for unfinished jobs....
[  358s] /home/abuild/rpmbuild/BUILD/mozjs-24.2.0/js/src/shell/js.cpp: In function 'JSBool Evaluate(JSContext*, unsigned int, jsval*)':
[  358s] /home/abuild/rpmbuild/BUILD/mozjs-24.2.0/js/src/shell/js.cpp:1036:20: warning: '*((void*)(& ancx)+32).js::AutoCompartment::origin_' may be used uninitialized in this function [-Wmaybe-uninitialized]
[  358s]      AutoNewContext ancx;

Likely the patch is not too different from what was merged for mozjs17

Comment 1 Dominique Leuenberger 2017-05-16 19:20:02 UTC

For the record:

osc whatdependson openSUSE:Factory mozjs24 standard x86_64
mozjs24 :
   cinnamon
   cjs
   nemo-extensions
   python-python-spidermonkey


CCing the cinnamon maintainer - it would be nice to migrate cinnamon away from mozjs24 to something newer (latest is mozjs45 in the TW repos)

Comment 2 Dominique Leuenberger 2017-05-16 20:52:45 UTC

I just see cjs has a submission ready to be ported to mozjs-38 (that should include cinnamon and nemo-extenions)

meaning python-python-spidermonkey would be the only consumer left of mozjs24 shortly.

Comment 3 Alexei Sorokin 2017-05-16 22:41:12 UTC

Yep, cjs is already pending.

Comment 4 Dominique Leuenberger 2017-05-17 07:27:24 UTC

wit cinnamon being ported to mozjs-38, I filed a delete request for python-python-spidermonkey and mozjs24 - then there is no need to fix those for gcc7

Comment 5 Dominique Leuenberger 2017-05-29 09:30:10 UTC

Mozjs24 has been dropped from openSUSE:Factory