Bug 1049194

Summary:	Software Manager: The "Accept" button has an inconsistent behavior
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Adrien Plazas <adrien.plazas>
Component:	YaST2	Assignee:	YaST Team <yast-internal>
Status:	RESOLVED WONTFIX	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P4 - Low
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
URL:	https://trello.com/c/DpwEKJEL
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Adrien Plazas 2017-07-18 14:28:43 UTC

When clicking "Accept" when actions are pending, the actions are performed, but when no action id pending clicking the button quits Software Manager.

This behavior isn't obvious at all, and in the case where no actions are pending it has the exact same behavior as the "Cancel" button when their names implies opposite action.

I would suggest to hide or make insensitive the "Accept" button when no actions are pending.

Comment 1 Steffen Winterfeldt 2017-07-19 13:11:12 UTC

Yes, indeed. You basically accept 'do nothing'.

The button might be grayed out (like 'save' buttons until there are changes to save).

Comment 2 Steffen Winterfeldt 2017-07-19 13:12:59 UTC

tracking in yast trello board

Comment 3 Stefan Hundhammer 2019-05-21 14:19:54 UTC

I strongly disagree.

"Accept" means "apply all pending changes and then proceed". Depending on how this module is configured, you might get an after-action report, after which the workflow is done, or it might be done immediately.

"Cancel" means "discard all changes and get me out of here".


So, if you didn't change anything, indeed it appears as if the same thing happens: The program exits.

Disabling the "Accept" button in that situation would only add another level of complexity to the user interface for no good reason at all. Why make life harder for the users without a good reason?

Comment 4 Stefan Hundhammer 2019-05-21 14:20:46 UTC

There is no inconsistency. You just have different expectations.