Bug 1052058

Summary: Gnome: _NET_RESTACK_WINDOW does nothing
Product: [openSUSE] openSUSE Distribution Reporter: Forgotten User izAw07lp5v <forgotten_izAw07lp5v>
Component: GNOMEAssignee: Vasilis Liaskovitis <vliaskovitis>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: astieger, fezhang, forgotten_izAw07lp5v, msrb, vliaskovitis
Version: Leap 42.2   
Target Milestone: ---   
Hardware: x86-64   
OS: openSUSE 42.2   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: Test program
Test program

Description Forgotten User izAw07lp5v 2017-08-03 11:07:04 UTC
Created attachment 735119 [details]
Test program

_NET_RESTACK_WINDOW protocol seems not to be implemented, see test program.
Comment 1 Forgotten User izAw07lp5v 2017-08-03 11:10:40 UTC
Created attachment 735120 [details]
Test program
Comment 2 Felix Zhang 2017-08-03 13:51:19 UTC
CC'ing the Xorg experts.
Comment 3 Andreas Stieger 2017-08-03 14:08:34 UTC
dup

*** This bug has been marked as a duplicate of bug 1052016 ***
Comment 4 Forgotten User izAw07lp5v 2017-08-03 15:54:25 UTC
This is not the same as
https://bugzilla.suse.com/show_bug.cgi?id=1052016
1052016 is for KDE3 where "Below" flag places window on bottom of the stack instead just below the the sibling. This report is for GNOME where _NET_RESTACK_WINDOW message does nothing.
Comment 5 Andreas Stieger 2017-08-10 06:59:16 UTC
reopen th
Comment 6 Michal Srb 2017-08-15 09:27:26 UTC
(In reply to Felix Zhang from comment #2)
> CC'ing the Xorg experts.

The _NET_RESTACK_WINDOW event has to be handled by the window manager. X server is not involved.
Comment 7 Felix Zhang 2017-08-15 19:14:43 UTC
Sorry Michal, I overlooked it. It is true _NET_RESTACK_WINDOW is missing in mutter. Seen from the git log, there was a very old implementation in 2004 but never enabled, the code was described as "broken" and finally dropped in 2014.

So I see this as a missing feature in GNOME and should be reported upstream rather than fixed in a distribution. I'm closing this as resolved - upstream. Please feel free to reopen if needed.
Comment 8 Forgotten User izAw07lp5v 2017-08-16 06:13:20 UTC
Can you write where to report exactly and what to write so it gets noticed by the right people?
Comment 9 Felix Zhang 2017-08-16 11:04:46 UTC
Yes Martin. Sorry I missed that.

The GNOME bugzilla:
https://bugzilla.gnome.org/

Quick link to report bugs in mutter:
https://bugzilla.gnome.org/enter_bug.cgi?product=mutter

A similar bug report as an example:
https://bugzilla.gnome.org/show_bug.cgi?id=654760
Comment 10 Felix Zhang 2017-08-17 03:26:39 UTC
I see Martin has reported this to upstream:
https://bugzilla.gnome.org/show_bug.cgi?id=786363
Comment 11 Vasilis Liaskovitis 2017-08-18 14:03:49 UTC
Assigning to me, as I submitted a patch at the upstream bugzilla. It seems to work for my local tests.
Comment 12 Vasilis Liaskovitis 2017-09-20 12:18:13 UTC
Upstream has reviewed my patch for https://bugzilla.gnome.org/show_bug.cgi?id=786363, but not the follow up patch for similar https://bugzilla.gnome.org/show_bug.cgi?id=786365. They have not been merged to master yet.

The patches worked for me, but it would be good to get feedback from the reporter. @Martin, can you test with the following mutter packages, which contain the patches?
http://download.opensuse.org/repositories/home:/vliaskovitis:/branches:/openSUSE:/Leap:/42.2:/Update/standard/x86_64/

If you can confirm they work for you, we could apply the fixes to openSUSE packages even before they are merged upstream.
Comment 13 Forgotten User izAw07lp5v 2017-09-21 14:01:58 UTC
It works with the test programs but with MSEide in more complex situations there still are problems, sometimes an "above" window which should be on top is below one or two windows where KDE in the same situation behaves correct.
Comment 14 Vasilis Liaskovitis 2017-09-21 14:14:56 UTC
(In reply to Martin Schreiber from comment #13)
> It works with the test programs but with MSEide in more complex situations
> there still are problems, sometimes an "above" window which should be on top
> is below one or two windows where KDE in the same situation behaves correct.

thanks for the feedback. Can you provide a more complex test case that still fails, and link it in the upstream bug, so that we can take a look? If that is not possible, then a link to the whole MSEide GNOME port repo and instructions on how to trigger the issue would be needed (again in the upstream bug).
Comment 15 Forgotten User izAw07lp5v 2017-09-23 05:29:39 UTC
Done.
https://bugzilla.gnome.org/show_bug.cgi?id=786365#c3
Comment 16 Vasilis Liaskovitis 2017-09-28 16:12:44 UTC
Thank you. Could you retest with the new mutter packages from here:

http://download.opensuse.org/repositories/home:/vliaskovitis:/branches:/openSUSE:/Leap:/42.2:/Update/standard/x86_64/
Comment 17 Forgotten User izAw07lp5v 2017-09-29 12:38:57 UTC
Both test-programs run OK, also with MSEide I found no more problems. Thank you very much!
Comment 18 Bernhard Wiedemann 2017-10-03 12:01:11 UTC
This is an autogenerated message for OBS integration:
This bug (1052058) was mentioned in
https://build.opensuse.org/request/show/530822 Factory / mutter
Comment 20 Vasilis Liaskovitis 2017-11-10 13:15:07 UTC
Thank you. Martin, the fixes have been pushed to maintenance - if there is still an issue with the next version of the package let us know. Closing bug.
Comment 22 Swamp Workflow Management 2019-01-10 23:12:36 UTC
SUSE-RU-2019:0068-1: An update that has 5 recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1017412,1024748,1045440,1052058,1093541
CVE References: 
Sources used:
SUSE Linux Enterprise Software Development Kit 12-SP4 (src):    mutter-3.20.3-16.12.1
SUSE Linux Enterprise Software Development Kit 12-SP3 (src):    mutter-3.20.3-16.12.1
SUSE Linux Enterprise Server 12-SP4 (src):    mutter-3.20.3-16.12.1
SUSE Linux Enterprise Server 12-SP3 (src):    mutter-3.20.3-16.12.1
SUSE Linux Enterprise Desktop 12-SP4 (src):    mutter-3.20.3-16.12.1
SUSE Linux Enterprise Desktop 12-SP3 (src):    mutter-3.20.3-16.12.1
Comment 23 Swamp Workflow Management 2019-01-13 23:12:49 UTC
openSUSE-RU-2019:0049-1: An update that has 5 recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1017412,1024748,1045440,1052058,1093541
CVE References: 
Sources used:
openSUSE Leap 42.3 (src):    mutter-3.20.3-6.3.1