Bug 1055322

Summary:	Botan fails to build with OpenSSL 1.1
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Vítězslav Čížek <vcizek>
Component:	Other	Assignee:	Daniel Molkentin <daniel>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None	CC:	thb, vcizek, wbauer
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	1042629

Description Vítězslav Čížek 2017-08-23 15:42:36 UTC

The package fails to build with OpenSSL 1.1.
We need to migrate Factory to OpenSSL 1.1 as it will become the default on SLE-15. For more information see the blocker bug.

Currently testing in a staging project:
https://build.opensuse.org/project/show/openSUSE:Factory:Staging:SSL11
Fails with:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:SSL11/Botan/standard/x86_64

Comment 1 Vítězslav Čížek 2017-08-23 15:43:13 UTC

OpenSSL 1.1 is supported by the recently released 2.2.0:
https://github.com/randombit/botan/blob/master/news.rst#version-220-2017-08-07

Stable branch (1.10) likely won't get the support backported:
https://github.com/randombit/botan/issues/753

Comment 2 Daniel Molkentin 2017-08-28 10:45:19 UTC

I have submitted 2.2.0 to factory. For the only user of Botan 1 in our code base that I am aware of, Qt Creator, I have opened an issue: https://bugreports.qt.io/browse/QTCREATORBUG-18802.

Comment 3 Daniel Molkentin 2017-08-28 10:54:45 UTC

My suggestion is to drop Botan1 the moment we have a patch for Qt Creator.

Comment 4 Vítězslav Čížek 2017-09-12 13:00:28 UTC

PowerDNS (pdns) also requires Botan 1.10, but it recently moved towards OpenSSL:
https://blog.powerdns.com/2016/07/11/powerdns-authoritative-server-4-0-0-released

Botan 1.10 is now used there only to provide GOST support.
It can be built without it.

Comment 7 Vítězslav Čížek 2017-09-21 10:11:02 UTC

For Factory, we'll explicitly require libopenssl-1_0_0-devel to build even after we switch the default openssl to 1.1.
https://build.opensuse.org/request/show/527707

Ultimately, we want to drop the Botan (1.x) package.

Comment 8 Daniel Molkentin 2017-09-28 11:56:50 UTC

Now that the request got accepted, I'll close this ticket. Feel free to send a drop request once we have a solution for QtCreator, which is afaik the sole application requiring Botan1.

Comment 9 Vítězslav Čížek 2017-09-29 13:53:48 UTC

> osc whatdependson openSUSE:Factory Botan standard x86_64
Botan :
   libqca-qt5
   libqt5-creator
   pdns
   pdns-recursor

I'm dropping Botan from pdns packages in requests
https://build.opensuse.org/request/show/529940
https://build.opensuse.org/request/show/529941

Comment 10 Wolfgang Bauer 2017-09-29 15:02:05 UTC

(In reply to Vítězslav Čížek from comment #9)
> > osc whatdependson openSUSE:Factory Botan standard x86_64
> Botan :
>    libqca-qt5

That one is actually superfluous and can just be removed.
Building the botan plugin is explicitly disabled anyway:
%cmake \
      -DQT4_BUILD=OFF \
      -DBUILD_TESTS=OFF \
      -DQCA_INSTALL_IN_QT_PREFIX=ON \
      -DWITH_botan_PLUGIN=OFF \  <=====================
      -DQCA_BINARY_INSTALL_DIR:PATH="%{_bindir}" \
      -DQCA_MAN_INSTALL_DIR:PATH="%{_mandir}" \
      -DQCA_SUFFIX=qt5

I created a submit request that removes the bogus BuildRequires:
https://build.opensuse.org/request/show/529961

Comment 11 OBSbugzilla Bot 2022-03-29 09:50:03 UTC

This is an autogenerated message for OBS integration:
This bug (1055322) was mentioned in
https://build.opensuse.org/request/show/965583 Backports:SLE-12-SP4 / pdns
https://build.opensuse.org/request/show/965588 Backports:SLE-12-SP4 / pdns-recursor