Bug 1075828

Summary:	yast keyboard: stop using KEYTABLE sysconfig variable
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Stanislav Brabec <sbrabec>
Component:	YaST2	Assignee:	Josef Reidinger <jreidinger>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P5 - None	CC:	fbui, jreidinger, ms
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Stanislav Brabec 2018-01-12 16:19:12 UTC

Console keyboard settings was refactored (see bug 1010880).

Variable KEYTABLE from /etc/sysconfig/keyboard is now obsolete. But it seems that it is still referenced by yast keyboard module.

Please review the module. /etc/vconsole.conf is now the only way to set the virtual console keymap.

Maybe the sysconfig variable YAST_KEYBOARD could be moved outside /etc/sysconfig/keyboard as well. It would need update of sysconfig.keyboard.del fillup template.

Variable KEYTABLE defined by kbd was used by systemd-vconsole-setup since 2013. Now it is not used any more (update is already in SLE 15/Leap 15, staging in Factory).

Comment 1 Stanislav Brabec 2018-01-12 16:36:35 UTC

I forgot to mention: COMPOSETABLE variable is obsolete as well.

Comment 3 Stanislav Brabec 2018-01-12 17:19:46 UTC

Also xkbctrl.1 from x11 module (but not xkbctrl itself) refers to KEYTABLE.
https://github.com/yast/yast-x11/blob/ddb2f84f147ed4e09dca4964cc2c6cbd55aa8bd8/src/tools/xkbctrl.1#L17

And country module refers to both KEYTABLE and COMPOSETABLE as well:
https://github.com/yast/yast-country/blob/a7c02eee6791900c3d22c958ff94668d9be9a5a4/keyboard/src/modules/Keyboard.rb#L878
https://github.com/yast/yast-country/blob/a7c02eee6791900c3d22c958ff94668d9be9a5a4/keyboard/src/modules/Keyboard.rb#L845

And country installing files do that as well:
https://github.com/yast/yast-country/blob/a7c02eee6791900c3d22c958ff94668d9be9a5a4/keyboard/test/data/installing/etc/sysconfig/keyboard
https://github.com/yast/yast-country/blob/a7c02eee6791900c3d22c958ff94668d9be9a5a4/keyboard/test/data/spanish/etc/sysconfig/keyboard

Comment 4 Josef Reidinger 2018-01-15 08:13:48 UTC

(In reply to Stanislav Brabec from comment #3)
> Also xkbctrl.1 from x11 module (but not xkbctrl itself) refers to KEYTABLE.
> https://github.com/yast/yast-x11/blob/
> ddb2f84f147ed4e09dca4964cc2c6cbd55aa8bd8/src/tools/xkbctrl.1#L17

I will check it.

> 
> And country module refers to both KEYTABLE and COMPOSETABLE as well:
> https://github.com/yast/yast-country/blob/
> a7c02eee6791900c3d22c958ff94668d9be9a5a4/keyboard/src/modules/Keyboard.
> rb#L878
> https://github.com/yast/yast-country/blob/
> a7c02eee6791900c3d22c958ff94668d9be9a5a4/keyboard/src/modules/Keyboard.
> rb#L845

Will check.

> 
> And country installing files do that as well:
> https://github.com/yast/yast-country/blob/
> a7c02eee6791900c3d22c958ff94668d9be9a5a4/keyboard/test/data/installing/etc/
> sysconfig/keyboard
> https://github.com/yast/yast-country/blob/
> a7c02eee6791900c3d22c958ff94668d9be9a5a4/keyboard/test/data/spanish/etc/
> sysconfig/keyboard

This is test only data. so not affect runtime ( see that it is in test directory ).

Comment 5 Josef Reidinger 2018-01-15 08:18:05 UTC

yast-x11 pull request https://github.com/yast/yast-x11/pull/16

Comment 6 Josef Reidinger 2018-01-15 08:53:31 UTC

yast2-country pull request https://github.com/yast/yast-country/pull/160

Comment 7 Josef Reidinger 2018-01-15 10:03:54 UTC

and yast2-update need also related pr https://github.com/yast/yast-update/pull/92

Comment 8 Josef Reidinger 2018-01-15 10:04:25 UTC

all pull requests merged, so closing as fixed.

Comment 9 Stanislav Brabec 2018-01-15 16:26:54 UTC

If you will update yast-country test data as well, you will probably prevent test case failure. One of the tests apparently expects Spanish keyboard.