Bug 1081517

Summary: Poor support of icons in YaST
Product: [openSUSE] openSUSE Tumbleweed Reporter: Sasi Olin <hel>
Component: YaST2Assignee: Forgotten User kWxJsf0s20 <forgotten_kWxJsf0s20>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Enhancement    
Priority: P5 - None CC: cwh
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on: 1109310, 1109378, 1109382, 1110236    
Bug Blocks:    

Description Sasi Olin 2018-02-19 09:03:56 UTC
YaST doesn't have support for external icon themes without making changes to links inside theme directory. Data inside of library/general/src/modules/Directory.rb in case of Wizard themes always has higher priority over system theme. In case of icons, removing icon symlink doesn't have effect on icon theme and falls back to hicolor, as opposed to system theme which affects YaST when there is no theme with higher priority in /usr/share/YaST2/theme/current/wizard directory.

Icon module in library/general/src/modules/Icon.rb doesn't take any other option than .png into account (it's not the only lib that does that). It would be nice to at least have additional support for SVG, even though it's optional in freedesktop standard (https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#definitions) (but I don't see you supporting .xpm, so at least support .svg which is at least somewhat popular on desktop).

I couldn't find mentions about pattern icons and package groups icons in software manager, but those don't even want to change with icon theme symlink (/usr/share/YaST2/theme/current/icons) changed to something different. It would be awesome if those followed the same spec. For now from users point of view they seem to be hardcoded and impossible to be changed to anything different.
Comment 1 Christopher Hofmann 2018-02-20 15:19:42 UTC
A nice feature that could be implemented by the community.
Comment 2 Sasi Olin 2018-02-20 15:23:23 UTC
(In reply to Christopher Hofmann from comment #1)
> A nice feature that could be implemented by the community.

I kinda started working on it:
https://github.com/yast/yast-control-center/pull/21
Although that is just a tip of the iceberg ;)
Comment 3 Sasi Olin 2018-11-30 18:06:40 UTC
All icons are now loaded from XDG specified locations.