Bug 1098924

Summary:	git send-email warns about bad file descriptors
Product:	[openSUSE] openSUSE Distribution	Reporter:	Andreas Färber <afaerber>
Component:	Development	Assignee:	Markéta Machová <mmachova>
Status:	RESOLVED DUPLICATE	QA Contact:	E-mail List <qa-bugs>
Severity:	Minor
Priority:	P4 - Low	CC:	afaerber
Version:	Leap 15.0	Flags:	tiwai: needinfo? (afaerber)
Target Milestone:	---
Hardware:	x86-64
OS:	SUSE Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Andreas Färber 2018-06-24 14:09:45 UTC

git send-email appeared to send emails okay, but printed the following warnings:

$ git send-email -1 --identity=foo --in-reply-to=bar
...
Result: 250 
Warning: unable to close filehandle properly: Bad file descriptor during global destruction.
Warning: unable to close filehandle properly: Bad file descriptor during global destruction.
Warning: unable to close filehandle properly: Bad file descriptor during global destruction.
Warning: unable to close filehandle properly: Bad file descriptor during global destruction.
$

Comment 1 Takashi Iwai 2018-06-26 06:02:42 UTC

It's an issue that happens with upstream version, too.  Please report it upstream.

Comment 2 Takashi Iwai 2018-10-31 11:32:38 UTC

Reassign to the new package maintainer.

Comment 3 Markéta Machová 2018-11-19 10:38:53 UTC

Andreas, did you already report the issue upstream?

Comment 4 Markéta Machová 2019-01-11 13:55:16 UTC

I was trying to strace the git send-email command with recent Tumbleweed (git version 2.20.1), but I had to prevent send-email from asking any questions (because of https://bugzilla.suse.com/show_bug.cgi?id=1120759) and it sent emails OK without complaints.

$ git send-email -1 --identity=foo --in-reply-to=bar --no-cc --to=mcalabkova@suse.de --confirm=never --transfer-encoding=8bit
(...)
Result: OK
$

I will try this combination on older git and let you know.

Comment 5 Markéta Machová 2019-01-11 15:04:49 UTC

I can not reproduce the bug even with git 2.20.0 and git 2.19.1 with the given parameters (on the same machine). It seems either some of the parameters fixed the bug (hardly possible) or it is somehow fixed by the same perl instalation which causes https://bugzilla.suse.com/show_bug.cgi?id=1120759. However, I can not test how it works without these parameters, because it always fails with good new bsc#1120759.

Comment 6 Markéta Machová 2019-01-15 08:58:39 UTC

There is another possibility: that the Term::Readline causes this bug as in bsc#1120759 (the minimal reproducer fails also with Warning: unable to close filehandle __ANONIO__ properly: Bad file descriptor during global destruction, which is similar to this issue), so it could be technically duplicate. Anyway, we will wait for the fix of bsc#1120759 and see whether or not is this issue fixed.

Comment 7 Markéta Machová 2019-01-17 13:07:21 UTC

I can confirm that upgrading perl-TermReadLine-Gnu on my computer fixed the issue. Anyone else can test it?

Comment 8 Markéta Machová 2019-02-13 14:09:06 UTC

Noone responds. I suppose it is indeed a duplicate of bsc#1120759. Closing.

*** This bug has been marked as a duplicate of bug 1120759 ***