Bug 1101979

Summary: openSUSE Tumbleweed: Mounting a filesystem fails and libstorage-ng throws an exception
Product: [openSUSE] openSUSE Tumbleweed Reporter: Forgotten User pvtROBX6bm <forgotten_pvtROBX6bm>
Component: InstallationAssignee: David Diaz <dgonzalez>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P3 - Medium CC: aschnell, dgonzalez, forgotten_pvtROBX6bm, kanderssen, rbrown
Version: Current   
Target Milestone: ---   
Hardware: x86-64   
OS: openSUSE Factory   
URL: https://trello.com/c/ZfOQQTv3
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: Includes dmesg, hwinfo, /var/log/messages and y2logs.tgz.
y2logs
/var/log/messages output
dmesg output
hwinfo output
yast2 error message screenshot 1
yast2 error message screenshot 2
MSFTRES partition formatted as NTFS
MSFTRES partition formatted as ext4

Description Forgotten User pvtROBX6bm 2018-07-20 00:21:17 UTC
Created attachment 777536 [details]
Includes dmesg, hwinfo, /var/log/messages and y2logs.tgz.

After accepting the terms of license and choosing the desired desktop, the network installer fails with the following messages.

«Details: storage::Exception Caller: /mounts/mp_0001/usr/share/YaST2/lib/y2storage/storage_class_wrapper.rb:260:in`detect_content_info`»

«Calling the Yast module 'inst_disk_proposal has failed. More information can be found near the end of the 'var/log/Yast2/y2log' file.» 

Relevant logs (including dmesg, hwinfo, /var/log/messages and y2logs.tgz) and screenshots are attached.
Comment 1 Forgotten User pvtROBX6bm 2018-07-20 00:31:48 UTC
Created attachment 777537 [details]
y2logs
Comment 2 Forgotten User pvtROBX6bm 2018-07-20 00:32:27 UTC
Created attachment 777538 [details]
/var/log/messages output
Comment 3 Forgotten User pvtROBX6bm 2018-07-20 00:33:12 UTC
Created attachment 777539 [details]
dmesg output
Comment 4 Forgotten User pvtROBX6bm 2018-07-20 00:33:37 UTC
Created attachment 777540 [details]
hwinfo output
Comment 5 Forgotten User pvtROBX6bm 2018-07-20 00:34:45 UTC
Created attachment 777541 [details]
yast2 error message screenshot 1
Comment 6 Forgotten User pvtROBX6bm 2018-07-20 00:35:50 UTC
Created attachment 777542 [details]
yast2 error message screenshot 2
Comment 7 Richard Brown 2018-07-20 08:13:32 UTC
Logs show the following

> 2018-07-20 00:38:01 <3> install(4507) [libstorage] SystemCmd.cc:97 mount: /tmp/libstorage-Ipmikv/tmp-mount-YQuvvH: wrong fs type, bad option, bad superblock on /dev/sda2, missing codepage or helper program, or other error.

storage-inst/01-probed.yml suggests that sda2 is an ext4 partition of 16MiB in size, with an id: microsoft_reserved

This sounds very confusing, why would an ext4 partition be so small and with an id that implies a relation to a windows installation?

Can you provide any light onto this? What would you expect that 16MiB partition on your system to be?
What filesystem would you expect it to already be?

I'm asking to try and get more info to help the YaST team identifiy whether this bug is a problem with their detection (did it incorrectly identify the file_system for sda2?) or with insufficient handling of a very bizarre problem with your unusual/broken disk layout.

Please reply to this question and choose the tickbox to clear the NEEDINFO request when you do

Thanks!
Comment 8 Forgotten User pvtROBX6bm 2018-07-20 20:19:01 UTC
(In reply to Richard Brown from comment #7)
> Logs show the following
> 
> > 2018-07-20 00:38:01 <3> install(4507) [libstorage] SystemCmd.cc:97 mount: /tmp/libstorage-Ipmikv/tmp-mount-YQuvvH: wrong fs type, bad option, bad superblock on /dev/sda2, missing codepage or helper program, or other error.
> 
> storage-inst/01-probed.yml suggests that sda2 is an ext4 partition of 16MiB
> in size, with an id: microsoft_reserved
> 
> This sounds very confusing, why would an ext4 partition be so small and with
> an id that implies a relation to a windows installation?
> 
> Can you provide any light onto this? What would you expect that 16MiB
> partition on your system to be?
> What filesystem would you expect it to already be?
> 
> I'm asking to try and get more info to help the YaST team identifiy whether
> this bug is a problem with their detection (did it incorrectly identify the
> file_system for sda2?) or with insufficient handling of a very bizarre
> problem with your unusual/broken disk layout.
> 
> Please reply to this question and choose the tickbox to clear the NEEDINFO
> request when you do
> 
> Thanks!

Thank you for reaching out.

Yes that's correct, there's a ext4 formatted partition of 16 MiB in size and with id microsoft reserved partition. I confirm Yast did detect correctly the partition filesystem. 

And yes, it's odd that this partition is formatted as ext4.

Today I successfully installed Tumbleweed on another laptop I had access to. I used the same network installer and the same USB pendrive. On this other laptop, the Microsoft reserved partition is formatted as NTFS rather than ext4.

I will attach both disk partition layouts for comparison. 

If I recall correctly, this ext4 partition was created a year ago when I made a clean Windows install on this disk (instead of restoring from the OEM image). I remember Windows 10 complaining and requiring the existence of such a "Microsoft reserved partition" on the disk for successful installation, which after googling for a while, I proceeded to create. It's likely that I created this partition using GParted on a Live USB system and chose ext4 arbitrarily, since as far as I can remember, because the actual filesystem of this partition did not matter for Windows 10, just its existence of the disk. 

In the meantime, I did at least once successful Tumbleweed installation on this same disk with the same partition layout, and also of at least two other different Linux distributions.
Comment 9 Forgotten User pvtROBX6bm 2018-07-20 20:21:10 UTC
Created attachment 777666 [details]
MSFTRES partition formatted as NTFS
Comment 10 Forgotten User pvtROBX6bm 2018-07-20 20:21:39 UTC
Created attachment 777667 [details]
MSFTRES partition formatted as ext4
Comment 11 Knut Alejandro Anderssen González 2018-07-23 10:33:21 UTC
Arvin, 

Could you check it?
Comment 12 Arvin Schnell 2018-07-23 21:04:14 UTC
Mounting the filesystem in question fails thus libstorage-ng throws and exception
which is not handled in yast2-storage-ng. I suppose it should be handled at
https://github.com/yast/yast-storage-ng/blob/master/src/lib/y2storage/disk_analyzer.rb#L209.
Comment 13 David Diaz 2018-09-19 16:05:15 UTC
After discuss the solution with the Storage PO, we decided to log an error and not considered as windows partition in this scenario.

PR: https://github.com/yast/yast-storage-ng/pull/741
MR: https://build.opensuse.org/request/show/636678

Thank you.