Bug 1105654

Summary: mesa-dri-nouveau: Incorrect description when confirming the package license
Product: [openSUSE] openSUSE Tumbleweed Reporter: Lenz Grimmer <lgrimmer>
Component: InstallationAssignee: YaST Team <yast-internal>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Minor    
Priority: P3 - Medium CC: jreidinger, lubos.kocman, ma, sndirsch
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
URL: https://trello.com/c/1wc3PkX1
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Lenz Grimmer 2018-08-22 15:04:04 UTC
During the initial installation on my physical system using the openSUSE-Tumbleweed-NET-x86_64-Snapshot20180818-Media.iso image, I receive a popup window with the following title:

"Confirm Package License: Mesa-dri-nouveau"

The last paragraph of the message that is displayed here (which isn't actually a "license", but rather a warning/disclaimer) reads:

'Please click "Accept" if you accept the risks that may come with the installation of this driver. Choose "Cancel" to prevent installation of the driver and use software emulation instead.'

However, the popup window does not provide any buttons with these labels - they are labeled "I Agree" and "I Disagree".

I guess the text of that message should probably be updated to reflect this change (and eventually any other package that contains a similar message?).
Comment 1 Josef Reidinger 2018-08-23 08:11:34 UTC
I worry it is caused by fact that text is adapted to zypper message and not yast one.
Comment 2 Lenz Grimmer 2018-09-18 12:16:47 UTC
(In reply to Josef Reidinger from comment #1)
> I worry it is caused by fact that text is adapted to zypper message and not
> yast one.

On the command line (running "zypper dup", it looks as follows, which isn't any better:

[CUT]
Please click "Accept" if you accept the risks that may come with the
installation of this driver. Choose "Cancel"  to prevent installation
of the driver and use software emulation instead.
Do you agree with the terms of the license? [yes/no] (no):  
[CUT]
Comment 3 Stefan Hundhammer 2018-09-24 14:44:30 UTC
AFAIK those messages come from the repo, i.e. libzypp. The intention was that they should really be license agreements, not generic disclaimers of any kind that require arbitrary answers.

So I fear for this particular example, somebody took that too far and really misused the mechanism to also present Yet Another Disclaimers That All Users Hate (YADTAUH) and at the same time went overboard with the message.

IMHO the message (if it is needed at all, but that's not for us, the YaST team, to decide) needs to be reworded to fit into the existing user interfaces. There is just no way that we can handle arbitrary texts with arbitrary possible answers.

It was meant for licenses, so the wording in YaST was - after a very long discussion with involved stakeholders - chosen

  [I Agree]  [I Disagree]

to avoid any slightest chance of misunderstanding - which is not always the case with just "yes" or "no".

So IMHO this needs to be changed by the maintainers of that package to fit into that scheme. Misusing such a facility DOES come at a price. ;-)
Comment 6 Stefan Dirsch 2018-09-24 19:08:04 UTC
Could be that we misused this mechanism. I could adjust the text if I would know, where to find the text. Looks like it's outside of the buildservice. It's not inside the Mesa package sources. :-( Must be some magic during image build ...
Comment 7 Stefan Dirsch 2018-10-02 14:22:13 UTC
Created pull request.

  https://github.com/openSUSE/openSUSE-EULAs/pull/6
Comment 8 Stefan Dirsch 2018-10-04 12:55:53 UTC
Sooner or later the pull request will be accepted and openSUSE-EULAs package updated in TW. Therefore closing as fixed.
Comment 9 Lubos Kocman 2020-06-24 12:46:27 UTC
More likely later, Merged. Thank you! https://github.com/openSUSE/openSUSE-EULAs/pull/6
Comment 10 OBSbugzilla Bot 2020-06-24 13:20:07 UTC
This is an autogenerated message for OBS integration:
This bug (1105654) was mentioned in
https://build.opensuse.org/request/show/816831 15.2 / openSUSE-EULAs
Comment 11 OBSbugzilla Bot 2022-02-25 12:00:03 UTC
This is an autogenerated message for OBS integration:
This bug (1105654) was mentioned in
https://build.opensuse.org/request/show/957570 15.4 / openSUSE-EULAs