Bug 1113164

Stasiek - insts-sys is very limited as it eats memory, so to allow installation also on low end computers we restrict it.

Curently it uses Helvetica font - see https://github.com/openSUSE/installation-images/blob/master/data/root/root.file_list#L511

if you want another fonts, can you please which exact files you need? As we cannot add all fonts and all variants, so really minimal needed for installation.

Hm, interesting.

We can actually remove Raleway: https://github.com/openSUSE/installation-images/blob/master/data/root/root.file_list#L553

Variants used in installer would be:
Source Sans Pro Regular /usr/share/fonts/truetype/SourceSansPro-Regular.ttf
Source Sans Pro Light /usr/share/fonts/truetype/SourceSansPro-Light.ttf
Source Sans Pro Semibold /usr/share/fonts/truetype/SourceSansPro-Semibold.ttf
Open Sans Condensed Bold /usr/share/fonts/truetype/OpenSans-CondBold.ttf

We should probably switch to Source Sans Regular as default for openSUSE anyway.

(In reply to Stasiek Michalski from comment #2)
> Hm, interesting.
> 
> We can actually remove Raleway:
> https://github.com/openSUSE/installation-images/blob/master/data/root/root.
> file_list#L553
> 
> Variants used in installer would be:
> Source Sans Pro Regular /usr/share/fonts/truetype/SourceSansPro-Regular.ttf
> Source Sans Pro Light /usr/share/fonts/truetype/SourceSansPro-Light.ttf
> Source Sans Pro Semibold /usr/share/fonts/truetype/SourceSansPro-Semibold.ttf
> Open Sans Condensed Bold /usr/share/fonts/truetype/OpenSans-CondBold.ttf
> 
> We should probably switch to Source Sans Regular as default for openSUSE
> anyway.

Please note that installation images is shared with SLE and SourceSansPro is currently not in SLE. So before removing Raleway I need to check if it is not used in SLE.

We also need to inform openQA guys about this change as I worry it means complete regeneration of openqa test.

Rodion - What is your opinion about above?

Stasiek - please also make sure that it will works with variant locales. We already have some code that adds some exotic fonts for some installation locales like e.g. https://github.com/openSUSE/installation-images/blob/master/data/root/lang_fonts

(In reply to Josef Reidinger from comment #3)
> (In reply to Stasiek Michalski from comment #2)
> > Hm, interesting.
> > 
> > We can actually remove Raleway:
> > https://github.com/openSUSE/installation-images/blob/master/data/root/root.
> > file_list#L553
> > 
> > Variants used in installer would be:
> > Source Sans Pro Regular /usr/share/fonts/truetype/SourceSansPro-Regular.ttf
> > Source Sans Pro Light /usr/share/fonts/truetype/SourceSansPro-Light.ttf
> > Source Sans Pro Semibold /usr/share/fonts/truetype/SourceSansPro-Semibold.ttf
> > Open Sans Condensed Bold /usr/share/fonts/truetype/OpenSans-CondBold.ttf
> > 
> > We should probably switch to Source Sans Regular as default for openSUSE
> > anyway.
> 
> Please note that installation images is shared with SLE and SourceSansPro is
> currently not in SLE. So before removing Raleway I need to check if it is
> not used in SLE.
> 
> We also need to inform openQA guys about this change as I worry it means
> complete regeneration of openqa test.
> 
> Rodion - What is your opinion about above?

Sorry for the late response, somehow I didn't get e-mail notification for this needinfo. Replacing fonts will break all openQA tests and will require recreation of quite some needles. However, it's the price we pay, and that's why I'm trying to push for that UI framework. I would clarify what is our priority - better looking fonts + risks of missing some for translations or lightweight installer, which can be addressed with ncurses. 
I hope it helps.

> 
> Stasiek - please also make sure that it will works with variant locales. We
> already have some code that adds some exotic fonts for some installation
> locales like e.g.
> https://github.com/openSUSE/installation-images/blob/master/data/root/
> lang_fonts

Jiri, what do you think about it ?

(In reply to Josef Reidinger from comment #3)
> Please note that installation images is shared with SLE and SourceSansPro is
> currently not in SLE. So before removing Raleway I need to check if it is
> not used in SLE.

That's only true to some degree - and must not be used as an argument to have openSUSE progress (installation-images is a flavored package already, using _multibuild)

… and must not be used as an argument to have openSUSE progress *halted*

I should finish my sentences

Apparently this topic still needs some discussion and a final decision from
a YaST product owner. I added a card to the YaST trello task board so that
the issue is prioritised with the other tasks.

Let's summarize the facts

- SLE and openSUSE themes are and will be evolving
- Most probably in different way
- They share installation-images
- Themes are under "our control", but we (YaST team) do not develop them
- Fonts (and other things) are and will be changing and we need to find
  a non-hacky way to react on that easily

SO, the PO's cut is: Follow the development of themes and adjust
installation-images accordingly.

Unsolved, but related questions

- Who decides on changes in themes? Till it works somehow, looks better and  
  better, I don't think it's our (YaST team) business. We just take care that
  changes are done in technically correct way.
- Can themes change the look and break openQA needles? Is it worth it? From
  my POV, it's on openSUSE/TW PjM and QA guys to discuss the pros&cons, and
  however they decide, we should follow their decision (the same applies to
  SLE)

These questions do not block our work: Adjusting installation-images to
show YaST as intended by UI guys. These changes are ideally automatic,
so we don't need to manually scan for used fonts, create PR, etc.

From a practical perspective I would suggest:

1. make fonts a Requires of the yast branding packages (yast2-qt-branding-openSUSE, I guess) and keep this up-to-date in future

2. have a look at https://github.com/openSUSE/installation-images/blob/master/data/root/root.file_list#L540-L574
and identify what can be removed

3. keep in mind that apart from these fonts there are the big CJK blobs like arphic-uming-fonts that are loaded on demand defined here: https://github.com/openSUSE/installation-images/blob/master/data/root/config

If it turns out that 1. uses font packages that contain much more font files than actually needed and we're wasting too much space, we'll have to think again.


BTW1, adobe-sourcesanspro has both OpenType and TrueType files. Any preference here?

BTW2, are really *both* google-opensans and adobe-sourcesanspro needed? Is sticking to one of them so visually displeasing?

BTW3, is there a reason why there's still yast2-qt-branding-openSUSE vs.
yast2-theme-SLE (and some seemingly dummy yast2-theme-openSUSE) package?
Hadn't the branding package structure been reworked recently?

> If it turns out that 1. uses font packages that contain much more font files
> than actually needed and we're wasting too much space, we'll have to think
> again.

I actually suggested on IRC to subpackage parts of the fonts we need in theme, for the sake of keeping this relatively tidy.

> BTW1, adobe-sourcesanspro has both OpenType and TrueType files. Any
> preference here?

None, I would stick to what was used previously though ;)

> BTW2, are really *both* google-opensans and adobe-sourcesanspro needed? Is
> sticking to one of them so visually displeasing?

Yes

> BTW3, is there a reason why there's still yast2-qt-branding-openSUSE vs.
> yast2-theme-SLE (and some seemingly dummy yast2-theme-openSUSE) package?
> Hadn't the branding package structure been reworked recently?

It has, yast2-theme-openSUSE pulls from YaST-theme on Github, and in the future will probably be discontinued due to:
* icons moving to modules
* reworking of YaST-timezone I'm planning for foreseeable future (I hope)
That way the only resource left there will be SUSE YaST Qt theme, which SUSE should have moved to their branding package for ease of development like openSUSE did a long time ago.

After looking at the way yast branding works with pieces distributed all over the world (SLES in 'yast-theme' on github, TW in 'branding' on github but spec in OBS) I decided to drop the 'require font packages idea'. Nobody will remember what to do when it comes to changing a font.

Instead I added a check and the image build will fail:

https://github.com/openSUSE/installation-images/pull/285

The current situation seems to be this (at least the script reports this):

- SLE needs raleway, so I can't drop it
- openSUSE uses adobe-sourcesanspro (that package is not available on SLE, btw)
- nobody uses google-opensans so far

closing