Bug 1117221

It seems I've fixed the issue.
just add repo:
zypper ar https://download.opensuse.org/repositories/home:/vzhestkov:/leap15-gnome-update/openSUSE_Leap_15.0 leap15-gnome-updates
and move to updated packages
zypper dup --allow-vendor-change
The GNOME become more responsive and gnome-shell abnormal CPU utilization seems gone.
I'll be happy if anyone else could test it.

(In reply to Victor Zhestkov from comment #1)
> It seems I've fixed the issue.

Is it a huge change that was required? I wonder: Did you find the change that caused the problem, and just undid that change, or what's the issue?
More interestingly: Is this just a problem openSUSE users are experiencing, and if so, why? Or did users stop to look into the logfiles (and thus do not notice that they have a problem)?

Hi Ulrich.
It seems the issue was there since the release of Leap 15.0
I didn't see any changes with the updates.
My solution is to update mozjs52 first of all and then gjs and gnome-shell.
gjs and gnome-shell have some fixes with patches to avoid finalization of already finalized objects. mozjs52 just seems to have memory leaks and was updated to the latest version from 52 branch from Mozilla.
Other packages is not significant at all. For example gnome-music just has a bug with duplicated items in albums view.
gnome-terminal probably lead to some hangs of gnome-shell. I have no idea how is it related, but I saw situations when gnome-shell start eating whole the memory after intensive output in gnome-terminal.

(In reply to Victor Zhestkov from comment #3)
> (...) I have no idea
> how is it related, but I saw situations when gnome-shell start eating whole
> the memory after intensive output in gnome-terminal.

I noticed that gnome-terminal has a _huge_ scrollback buffer now (I haven't actually looked up the setting), so maybe that's where the memory went...

Not sure if it depends on the scroll size. More possible to some specific output. In two cases there were no much lines, but about 7-10 tabs opened with about 50-1000 lines each, not so much I suppose.

By the way, in most distros gdm is compiled with disabled output to the journal, this is the only reason why tweener.js messages are not in the journal.
But the issue itself, I believe, still there.

Your changes fix the error originally reported, but causes other errors instead that I didn't have before, like this one (yes, I use the gTile extension):

Feb 15 19:43:04 blackbox gnome-shell[8920]: JS ERROR: Exception in callback for signal: position-changed: TypeError: this._rect is undefined
                                            getCurrentRect@resource:///org/gnome/shell/ui/keyboard.js:547:22
                                            wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                            _onFocusPositionChanged@resource:///org/gnome/shell/ui/keyboard.js:612:20
                                            wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                            _emit@resource:///org/gnome/gjs/modules/signals.js:128:27
                                            _setCurrentWindow/this._currentWindowPositionId<@resource:///org/gnome/shell/ui/keyboard.js:528:21

Hi Olav.
Are you talking about my fixes?
Could you please send me an output of this command:
rpm -q --qf="%{NAME} %{VERSION} %{RELEASE} %{VENDOR}\n" gjs gnome-shell
What extensions are enabled on your system?

> Hi Olav.
> Are you talking about my fixes?

Yes, I'm talking about your fixes. And, like I mentioned, I am using the gTile extension, which is the one that produced the stack trace I intended to provide. :-) I have attached the correct stack trace.

The point of my comment was that, in case you planned to turn this into an update for Leap 15.0, I'd suggest you try to narrow the scope of the fix, since it seems to include unrelated changes.

> Could you please send me an output of this command:
> rpm -q --qf="%{NAME} %{VERSION} %{RELEASE} %{VENDOR}\n" gjs gnome-shell

I have reverted your fixes, so there's no point in running the rpm command you suggested, I guess. But these log statements, produced during the downgrade, are just as good, I believe:

Feb 15 19:47:55 blackbox [RPM][11581]: erase gjs-1.52.5-lp150.9.1.x86_64: success
Feb 15 19:47:55 blackbox [RPM][11581]: install gjs-1.50.4-lp150.2.1.x86_64: success

Feb 15 19:47:56 blackbox [RPM][11609]: erase gnome-shell-3.28.3-lp150.3.42.1.x86_64: success
Feb 15 19:47:56 blackbox [RPM][11609]: install gnome-shell-3.26.2+20180130.0d9c74212-lp150.3.3.1.x86_64: success

> What extensions are enabled on your system?

-Alternatetab
-Gtile(In reply to Victor Zhestkov from comment #7)

Created attachment 797098 [details]
New exception produced by proposed fixes

Olav, I've recompiled the packages in another repo. Could you please try it:
https://download.opensuse.org/repositories/home:/vzhestkov:/leap15-gnome-up/openSUSE_Leap_15.0/

The number of packages is limited in comparison with previous repo.

Please don't test the repo from my previous comment. Something is broken inside. I need to check and fix.

Created attachment 806701 [details]
Patch by Ray Strode <rstrode@redhat.com>

Hi Victor,

I just discovered that Ray Strode of RedHat has developed a patch to suppress the error messages mentioned in this bug report:

https://src.fedoraproject.org/rpms/gjs/blob/f27/f/disable-destoyed-object-criticals.patch

The patch applies cleanly to openSUSE:

https://build.opensuse.org/package/show/home:oreinert:branches:openSUSE:Leap:15.0/gjs

I've been running my system with the patch applied for a couple of days now, and for me this solution completely solves the problem, with no negative side-effects.

My suggestion would be to apply this patch to the gjs package in openSUSE. I would even submit the change myself if I could, but, because gjs is inherited from SLE, that doesn't seem to be an option, unfortunately.

What do you think, would this patch be a way to proceed?
If so, how do we get it done?

Hi Olav.
I've tried the other patch before, but there were some side effects related to it. I'll test this one on my system.
I don't know how to apply the patch to the channel. I think it's better to ask the maintainer.

This bug is also/still present in Leap 15.1.

Hi Olav.
I'm testing it on Leap 15.1
It seems ok. I'm using it almost 3 days and didn't notice any issues.

Thank you Olav and Victor for the finding and testing, I will submit this patch to STABLE:3.26 and 15:Update

Submitted: https://build.opensuse.org/request/show/708013

Request accepted

*** Bug 1127231 has been marked as a duplicate of this bug. ***

*** Bug 1113572 has been marked as a duplicate of this bug. ***

*** Bug 1115094 has been marked as a duplicate of this bug. ***

*** Bug 1135992 has been marked as a duplicate of this bug. ***

SUSE-RU-2019:1913-1: An update that has two recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1093541,1117221
CVE References: 
Sources used:
SUSE Linux Enterprise Module for Desktop Applications 15-SP1 (src):    gjs-1.50.4-4.5.1
SUSE Linux Enterprise Module for Desktop Applications 15 (src):    gjs-1.50.4-4.5.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.

openSUSE-RU-2019:1949-1: An update that has two recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1093541,1117221
CVE References: 
Sources used:
openSUSE Leap 15.1 (src):    gjs-1.50.4-lp151.4.3.1
openSUSE Leap 15.0 (src):    gjs-1.50.4-lp150.3.3.1