Bug 1128364

Summary: yast2-pkg-bindings: fails to build with boost 1.69.0
Product: [openSUSE] openSUSE Tumbleweed Reporter: Adam Majer <amajer>
Component: YaST2Assignee: E-mail List <yast2-maintainers>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P5 - None CC: bzeller, mvidner, zypp-maintainers
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Adam Majer 2019-03-07 15:36:51 UTC
boost's tribool now requires explicit cast to bool


[  108s] Source_Get.cc: In member function 'YCPValue PkgFunctions::SourceGeneralData(const YCPInteger&)':
[  108s] Source_Get.cc:172:103: error: no matching function for call to 'YCPBoolean::YCPBoolean(zypp::TriBool)'
[  108s]          data->add(YCPString("valid_repo_signature"), (YCPBoolean(repo->repoInfo().validRepoSignature())));
[  108s]                                                                                                        ^


https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:L/yast2-pkg-bindings/standard/x86_64
Comment 1 Adam Majer 2019-03-07 17:06:57 UTC
https://github.com/yast/yast-core/pull/140

Fixes the problem with yast2-pkg-bindings
Comment 2 Martin Vidner 2019-03-08 10:13:49 UTC
Thanks for the report!

FYI, this is the breaking change (and discussion) in Boost: https://github.com/boostorg/logic/pull/5

It may be better to put the implicit conversion into libzypp, we should check that.
Comment 3 Benjamin Zeller 2019-03-08 10:29:15 UTC
In libzypp we have changed our code to explicitely do the tribool conversion. 
IIRC there are tricky cases with implicit tribool conversion that give you 
a non expected result.
Comment 4 Martin Vidner 2019-03-08 12:20:10 UTC
Thanks, Benjamin.
Yes, as I have looked closer into it, I also prefer explicit conversions in specific places.

Fixed:
Git: https://github.com/yast/yast-pkg-bindings/pull/112
RPM: yast2-pkg-bindings-4.1.2
IBS: https://build.suse.de/request/show/186572
OBS: https://build.opensuse.org/request/show/682808