Bug 1134611

Summary: libindi: fails to build with boost 1.70.0 due to websocketpp
Product: [openSUSE] openSUSE Tumbleweed Reporter: Adam Majer <amajer>
Component: OtherAssignee: Cristian Rodríguez <crrodriguez>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: wbauer
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 1134606    

Description Adam Majer 2019-05-09 14:20:59 UTC
This is a bug indicating that a package for whom you are maintainer in openSUSE:Factory no longer builds with the proposed Boost 1.70.0 and as such will require patching. You can see your package failing to build at,

https://build.opensuse.org/package/show/home:adamm:boost_test/libindi

/usr/include/boost/asio/impl/executor.hpp:179:22: error: 'class std::reference_wrapper<boost::asio::io_context>' has no member named 'context'

https://stackoverflow.com/questions/39445636/alternative-to-deprecated-get-io-service

Please patch the problem and submit the fixes as Boost 1.70.0 will be shortly submitted to Factory.

If you are not maintainer, please let me know. Some packages do not have maintainers but only project maintainers, in which case I'm assigning the bug to the person doing most of recent changes and CC'ing the other maintainers.
Comment 1 Wolfgang Bauer 2019-05-09 16:34:56 UTC
This rather looks like a problem in websocketpp though, as that includes boost/asio:
[  102s] In file included from /usr/include/boost/asio/executor.hpp:338,
[  102s]                  from /usr/include/boost/asio/basic_waitable_timer.hpp:27,
[  102s]                  from /usr/include/boost/asio/steady_timer.hpp:22,
[  102s]                  from /usr/include/websocketpp/common/asio.hpp:61,
[  102s]                  from /usr/include/websocketpp/transport/asio/base.hpp:31,
[  102s]                  from /usr/include/websocketpp/transport/asio/connection.hpp:31,
[  102s]                  from /usr/include/websocketpp/transport/asio/endpoint.hpp:32,
[  102s]                  from /usr/include/websocketpp/config/asio_no_tls.hpp:32,
[  102s]                  from /home/abuild/rpmbuild/BUILD/indi-1.7.7/libindi/libs/indibase/indiwsserver.h:22,
[  102s]                  from /home/abuild/rpmbuild/BUILD/indi-1.7.7/libindi/libs/indibase/indiccd.h:34,
[  102s]                  from /home/abuild/rpmbuild/BUILD/indi-1.7.7/libindi/libs/indibase/indiccd.cpp:30:

Upstream bug report:
https://github.com/zaphoyd/websocketpp/issues/808
Comment 2 Wolfgang Bauer 2019-05-09 16:41:03 UTC
Reassigning to the websocketpp bug owner.

It seems that this PR should fix it:
https://github.com/zaphoyd/websocketpp/pull/814
Comment 3 Wolfgang Bauer 2019-05-09 16:50:17 UTC
(In reply to Wolfgang Bauer from comment #2)
> It seems that this PR should fix it:
> https://github.com/zaphoyd/websocketpp/pull/814

Confirmed. With this patch applied to websocketpp, libindi builds fine again.

https://build.opensuse.org/project/show/home:wolfi323:branches:home:adamm:boost_test
Comment 4 Wolfgang Bauer 2019-05-09 17:00:41 UTC
https://build.opensuse.org/request/show/701832
Comment 5 Wolfgang Bauer 2019-05-10 07:52:24 UTC
The updated websocketpp is in Factory now, and libindi built fine in the test branch:
https://build.opensuse.org/package/show/home:adamm:boost_test/libindi
Comment 6 Wolfgang Bauer 2019-05-10 07:54:38 UTC
*** Bug 1134609 has been marked as a duplicate of this bug. ***