Bug 1135723

Summary: Installation: Fstab Options window extended below screen bottom on 1280x800 screen
Product: [openSUSE] openSUSE Distribution Reporter: Felix Miata <mrmazda>
Component: YaST2Assignee: YaST Team <yast-internal>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P3 - Medium CC: aschnell
Version: Leap 15.1   
Target Milestone: Leap 15.2   
Hardware: x86-64   
OS: Other   
URL: https://trello.com/c/YWiwQnng
See Also: http://bugzilla.suse.com/show_bug.cgi?id=1161651
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: screenshot of Fstab Options window during NET 15.1 installation
y2logs .tgz
screenshot ncurses 80x24

Description Felix Miata 2019-05-21 08:41:58 UTC 
Created attachment 805561 [details]
screenshot of Fstab Options window during NET 15.1 installation

Original Summary:
Installation: Fstab Options window extended below screen bottom on 1280x800 screenS

This was on a Sony Vaio VGN CR290 laptop, not my own. Screens were mirrored.

Same window opened on first boot centered top to bottom of smaller screen, with expected resolutions:
> xrandr
Screen 0: minimum 320 x 200, current 3200 x 1200, maximum 8192 x 8192
LVDS-1 connected primary 1280x800+0+0 (normal left inverted right x axis y axis) 0mm x 0mm
   1280x800      60.00*+  59.99    59.97    59.81    59.91
   1280x720      60.00    59.99    59.86    59.74
   1024x768      60.04    60.00...
VGA-1 connected 1920x1200+1280+0 (normal left inverted right x axis y axis) 519mm x 324mm
   1920x1200     59.95*+
   1920x1080     60.00
   1680x1050     59.95
   1400x1050     59.98
   1280x1024     60.02
   1440x900      59.89
   1280x960      60.00
   1280x800      59.81...
SVIDEO-1 disconnected (normal left inverted right x axis y axis)
Comment 1 Felix Miata 2019-05-21 08:43:11 UTC 
Created attachment 805563 [details]
y2logs .tgz
Comment 2 Stefan Hundhammer 2019-05-21 13:05:27 UTC 
Right: That dialog has become much too overcrowded.

Those generic fstab options are put together depending on a filesystem type's capabilities, so it's hard to predict just how large it can become in the worst case.

Maybe we should think about using a MultiSelectionBox widget instead of all those individual CheckBox widgets: A MulitSelectionBox can scroll, so we could limit its total size.

We could also put the "mount by" options (UUID / label / ...) into a ComboBox; that would also save quite some screen space and get some complexity out of immediate sight.

If all that is not desired, we could also rearrange the layout and display some of those widgets side-by-side, e.g. all the CheckBox widgets. But we'll have to be careful to ensure everything still fits on a 80x24 NCurses screen.


Felix, thanks for pointing this out!
Comment 3 Stefan Hundhammer 2019-05-21 13:07:58 UTC 
AFAICS right now this should still fit on an 80x24 NCurses screen, but just barely with no room to spare.
Comment 4 Steffen Winterfeldt 2019-06-04 09:09:26 UTC 
Tracking in YaST Scrum board.
Comment 5 Arvin Schnell 2020-01-23 08:25:12 UTC 
Created attachment 828128 [details]
screenshot ncurses 80x24

Also in ncurses with 80x24 the dialog does not fit.
Comment 6 Arvin Schnell 2020-01-23 10:48:29 UTC 
As a first step we agreed to remove the acl and xattr options since
they are the default anyway these days (e.g. mount option noacl is
needed to turn acl off).

For UDF YaST also allows acl which even causes a mount failure.

For ext4 noacl will be removed as dmesg shows when using it:
"Mount option "noacl" will be removed by 3.5"

The next thing we agreed on is to remove the noatime option since
with relatime this should not be used by many people anymore. Also
when not checking noatime the result is not the old with atime on
since that would also require strictatime.
Comment 7 Felix Miata 2020-01-23 11:11:22 UTC 
Noatime I always use in preference to relatime. Often its my only mount option.

From man mount:
 relatime
...
              Since Linux 2.6.30, the kernel defaults to the behavior provided by this option (unless noatime was specified)
Comment 8 Arvin Schnell 2020-01-23 11:32:53 UTC 
You can still use the "Arbitrary Option Value" field.
Comment 9 Arvin Schnell 2020-01-24 18:13:20 UTC 
PR: https://github.com/yast/yast-storage-ng/pull/1034
Comment 10 Arvin Schnell 2020-01-27 09:17:17 UTC 
Fixed in yast2-storage-ng 4.2.78. Have a look at the PR above
for a screenshot.

The dialog still does not fit for VFAT. The idea is to split
the dialog into two, one for the mount by and volume and one
for the rest. That will be handled separately of this bug
report.