Bug 1154783

Summary:	grub-once is not called on hibernate
Product:	[openSUSE] openSUSE Distribution	Reporter:	Bernhard Wiedemann <bwiedemann>
Component:	Bootloader	Assignee:	Raymund Will <rw>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P2 - High	CC:	mchang
Version:	Leap 15.0
Target Milestone:	---
Hardware:	x86-64
OS:	All
Whiteboard:
Found By:	Development	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Bernhard Wiedemann 2019-10-22 19:06:31 UTC

https://build.opensuse.org/request/show/704131
added a check-setup function into /usr/lib/systemd/system-sleep/grub2.sleep
for bug 940457
but it introduced a bug in there that prevented grub-once from being called
(because set -e triggered).

The fix is trivial:
-	[ -n "$GRUB_SETUP" ] || return
+	[ -n "$GRUB_SETUP" ] || return 0

To check for this bug, use journalctl after resume and look for the entries after "grub2.sleep" - in the bad case they report a error 1
and the last printed line is about "preparing boot-loader"

Comment 2 Bernhard Wiedemann 2019-11-11 11:11:18 UTC

bug 940457 also introduced this bug in SLE-12-SP4 and SLE-15 GA (see comment 15 there)

Comment 8 Swamp Workflow Management 2019-12-17 17:49:45 UTC

SUSE-RU-2019:3324-1: An update that has two recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1136970,1154783
CVE References: 
Sources used:
SUSE Linux Enterprise Module for Server Applications 15 (src):    grub2-2.02-19.33.1
SUSE Linux Enterprise Module for Open Buildservice Development Tools 15 (src):    grub2-2.02-19.33.1
SUSE Linux Enterprise Module for Basesystem 15 (src):    grub2-2.02-19.33.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.

Comment 9 Swamp Workflow Management 2019-12-18 14:12:39 UTC

SUSE-RU-2019:3332-1: An update that has 6 recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1134287,1136086,1136970,1138991,1139345,1154783
CVE References: 
Sources used:
SUSE Linux Enterprise Server 12-SP5 (src):    grub2-2.02-12.18.1
SUSE Linux Enterprise Server 12-SP4 (src):    grub2-2.02-12.18.1
SUSE Linux Enterprise Desktop 12-SP4 (src):    grub2-2.02-12.18.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.

Comment 10 Swamp Workflow Management 2019-12-19 14:13:47 UTC

SUSE-RU-2019:3344-1: An update that has two recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1136970,1154783
CVE References: 
Sources used:
SUSE Linux Enterprise Module for Server Applications 15-SP1 (src):    grub2-2.02-26.9.2
SUSE Linux Enterprise Module for Open Buildservice Development Tools 15-SP1 (src):    grub2-2.02-26.9.2
SUSE Linux Enterprise Module for Basesystem 15-SP1 (src):    grub2-2.02-26.9.2

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.

Comment 11 Swamp Workflow Management 2020-01-13 23:33:57 UTC

openSUSE-RU-2020:0012-1: An update that has two recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1136970,1154783
CVE References: 
Sources used:
openSUSE Leap 15.1 (src):    grub2-2.02-lp151.21.9.1

Comment 12 Bernhard Wiedemann 2020-02-04 19:33:19 UTC

Leap 15.2 is still suffering from this bug, 
so probably the fix is missing in SLE-15-SP2 as well.

Comment 13 Michael Chang 2020-02-05 02:55:40 UTC

The auto-submission created by bot (origin-manager) to sync with factory was declined. I've created the SR and should land in SLE-15-SP2 soon. Sorry for the trouble.

Comment 16 Benjamin Brunner 2022-04-19 13:38:34 UTC

The fix is also in 15 SP2 for quite some time. Therefore, closing.

Thanks.