Bug 1166285

Summary: NFS Client setup runs into error in GetFstabEntry when pressing Cancel on the Add screen
Product: [openSUSE] openSUSE Distribution Reporter: Mészáros Gyula <meszaros.gyula>
Component: YaST2Assignee: YaST Team <yast-internal>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P3 - Medium CC: dgonzalez, jrivrain, lubos.kocman
Version: Leap 15.2   
Target Milestone: ---   
Hardware: x86-64   
OS: Other   
URL: https://trello.com/c/M2bqhsG4
See Also: https://bugzilla.suse.com/show_bug.cgi?id=1170447
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: yast2 nfs client bug - debug log
yast2 nfs client bug - before the error
yast2 nfs client bug - the error itself

Description Mészáros Gyula 2020-03-10 19:33:39 UTC
Created attachment 832456 [details]
yast2 nfs client bug - debug log

Open NFS Client setup in YaST2
Add a new share
On the Add screen navigate to the Cancel button and press it.
YaST2 NFS Client setup screen displays an error and exits.
Comment 1 Mészáros Gyula 2020-03-10 19:35:32 UTC
Created attachment 832457 [details]
yast2 nfs client bug - before the error
Comment 2 Mészáros Gyula 2020-03-10 19:36:04 UTC
Created attachment 832458 [details]
yast2 nfs client bug - the error itself
Comment 3 Martin Vidner 2020-03-18 18:02:15 UTC
Thanks for the report! I've reproduced it on the 20200314 snapshot of Tumbleweed.

Yes, this place in the code will break on Cancel
https://github.com/yast/yast-nfs-client/blob/71df8a961a7a978398f76e30fbaea2339e9c8113/src/include/nfs/ui.rb#L481

Internal error. 
Caller:  /usr/share/YaST2/include/nfs/ui.rb:481:in `GetFstabEntry'
Details: undefined method `[]=' for nil:NilClass
Comment 4 Martin Vidner 2020-03-25 12:52:21 UTC
*** Bug 1167654 has been marked as a duplicate of this bug. ***
Comment 5 David Diaz 2021-08-12 12:21:36 UTC
Hi!

Looks like just a month after this we got https://bugzilla.suse.com/show_bug.cgi?id=1170447, which is exactly the same bug report but we didn't marked it as a duplicated of this one. Anyway, the good news is that the problem was fixed more than a year ago! Please, excuse us for not notifying it here.

If interested, you can check the patch, included in yast2-nfs-client >= 4.2.8, at https://github.com/yast/yast-nfs-client/pull/95

Thanks!