Bug 1185720

Summary: nautilus fails to build with GCC11
Product: [openSUSE] openSUSE Tumbleweed Reporter: Richard Biener <rguenther>
Component: GNOMEAssignee: E-mail List <gnome-bugs>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: alynx.zhou, dleuenberger, yfjiang
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 1181859    

Description Richard Biener 2021-05-06 12:48:20 UTC
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:N/nautilus/standard/x86_64

note this is not yet 40.1 which is in GNOME:Factory but not Factory yet.
Comment 1 Alynx Zhou 2021-05-07 02:08:18 UTC
Upstream fix for glib is here: https://gitlab.gnome.org/GNOME/gcr/-/merge_requests/69
Comment 2 Alynx Zhou 2021-05-07 02:10:18 UTC
Sorry, this: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1719/diffs
Comment 3 Alynx Zhou 2021-05-07 02:18:22 UTC
This seems a big change and I am not sure whether we could backport it.
Comment 4 Yifan Jiang 2021-05-07 02:22:24 UTC
(In reply to Alynx Zhou from comment #2)
> Sorry, this: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1719/diffs

It seems in an earlier glib2 (2.67.1) than the Staging project used (2.68.1):

https://build.opensuse.org/build/openSUSE:Factory:Staging:N/standard/x86_64/nautilus/_log

Did I miss the point?
Comment 5 Alynx Zhou 2021-05-07 02:30:02 UTC
Ah, also a nautilus issue here: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1741
Comment 6 Yifan Jiang 2021-05-07 02:39:59 UTC
(In reply to Alynx Zhou from comment #5)
> Ah, also a nautilus issue here:
> https://gitlab.gnome.org/GNOME/nautilus/-/issues/1741

This also seems "old" fix of nautilus together with glib2 2.67.x, I assume the related MRs were in Factory already. Did you find which fixes of them was not yet used in our Factory?
Comment 7 Alynx Zhou 2021-05-07 02:52:07 UTC
Meson used for building is 0.56, and this fix (https://github.com/mesonbuild/meson/pull/7990/commits/0200340a497fb911c13ce3147b4223e4b5e290e7) is not in 0.56 I think.
Comment 8 Dominique Leuenberger 2021-05-07 07:22:16 UTC
(In reply to Alynx Zhou from comment #7)
> Meson used for building is 0.56, and this fix
> (https://github.com/mesonbuild/meson/pull/7990/commits/
> 0200340a497fb911c13ce3147b4223e4b5e290e7) is not in 0.56 I think.

Good catch - I just added that as a patch on the meson 0.56.2 package, submitted to Factory (newer meson versions need a systemd update, as the existing systemd version fails to build with it, thus going the patch route)
Comment 9 Alynx Zhou 2021-05-14 01:50:16 UTC
Could we close this bug now? It seems the patch has been merged.
Comment 10 Dominique Leuenberger 2021-05-14 08:49:55 UTC
(In reply to Alynx Zhou from comment #9)
> Could we close this bug now? It seems the patch has been merged.

yes, now we can close - we also have confirmation :N that this was indeed the last missing piece for nautilus vs gcc11