Bug 1188731

Summary:	resume param appears only for x86_64 in /proc/cmdline
Product:	[SUSE Linux Enterprise Server] PUBLIC SUSE Linux Enterprise Server 15 SP3	Reporter:	Joaquín Rivera <jeriveramoya>
Component:	YaST2	Assignee:	E-mail List <yast2-maintainers>
Status:	RESOLVED INVALID	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P5 - None	CC:	ancor, dgonzalez, jeriveramoya, jreidinger, yast2-maintainers
Version:	GMC
Target Milestone:	unspecified
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Joaquín Rivera 2021-07-27 07:29:19 UTC

In SLE 15 SP4 looks like only for x86_64 we see this parameter 'resume=' in /proc/cmdline
https://openqa.suse.de/tests/6518886#step/check_resume/4

For other archs keeps the same behavior than for SP3:
https://openqa.suse.de/tests/6518790#step/check_resume/2
https://openqa.suse.de/tests/6518561#step/check_resume/2
https://openqa.suse.de/tests/6520819#step/check_resume/2

Comment 1 David Diaz 2021-07-27 09:01:02 UTC

Hi Joaquín.

I have been checking the involved code and everything looks good. What is more, looks like hibernation (resume param) is only proposed in i386 and x86_64 architectures.

https://github.com/yast/yast-yast2/blob/0f51de045e5d3e700541ea08b040aa37ddc7c3f5/library/system/src/modules/Kernel.rb#L556-L563

But maybe I'm missing something. @Josef, could you have a look please?

Thanks!

Comment 2 Ancor Gonzalez Sosa 2021-07-27 10:03:04 UTC

I would say his works as expected. In this Jira entry it was requested to have a more advanced behavior depending on architecture, product and other criteria. https://jira.suse.com/browse/SLE-12280

But after the change was implemented as requested, it turned out some products/architectures were not so ready for hibernation as expected. So it was decided to revert the behavior to the much simpler:

- Hibernation is proposed by default in x86_64 
- Hibernation is NOT proposed for any other architecture

See the more recent comments in the referenced Jira entry for such summary. The decision was actually taken during the discussion on bug#1184470.

Comment 3 David Diaz 2021-07-27 11:25:03 UTC

(In reply to Ancor Gonzalez Sosa from comment #2)
> I would say his works as expected. In this Jira entry it was requested to
> have a more advanced behavior depending on architecture, product and other
> criteria. https://jira.suse.com/browse/SLE-12280
> 
> But after the change was implemented as requested, it turned out some
> products/architectures were not so ready for hibernation as expected. So it
> was decided to revert the behavior to the much simpler:
> 
> - Hibernation is proposed by default in x86_64 
> - Hibernation is NOT proposed for any other architecture
> 
> See the more recent comments in the referenced Jira entry for such summary.
> The decision was actually taken during the discussion on bug#1184470.

Thanks Áncor!

I have checked that, in fact, openQA tests linked above are using the yast2-4.3.63 which means that the mentioned revert is applied since it was sent in yast2-4.3.62[1]

So, I guess we can close this bug report. Joaquín, what do you think?

Comment 4 David Diaz 2021-07-27 11:26:00 UTC

(In reply to David Diaz from comment #3)
> ...
> sent in yast2-4.3.62[1]

[1] https://github.com/yast/yast-yast2/pull/1168

Comment 5 Joaquín Rivera 2021-07-27 11:32:01 UTC

sure, thanks for the info, we will update the test accordingly.

Comment 6 David Diaz 2021-07-27 11:35:45 UTC

So, closing as INVALID.

Thank you!