Bug 1195002

Related to
https://bugzilla.suse.com/show_bug.cgi?id=1195003

--clean is not a supported abbreviation of SUSEConnect. According to the --help output of the old SUSEConnect:

Usage: SUSEConnect [options]
Register SUSE Linux Enterprise installations with the SUSE Customer Center.
Registration allows access to software repositories (including updates)
and allows online management of subscriptions and organizations.

Manage subscriptions at https://scc.suse.com

    -p, --product [PRODUCT]  Specify a product for activation/deactivation. Only
                             one product can be processed at a time. Defaults to
                             the base SUSE Linux Enterprise product on this 
                             system. Product identifiers can be obtained
                             with `--list-extensions`.
                             Format: <name>/<version>/<architecture>
    -r, --regcode [REGCODE]  Subscription registration code for the product to
                             be registered.
                             Relates that product to the specified subscription,
                             and enables software repositories for that product.
    -d, --de-register        De-registers the system and base product, or in
                             conjunction with --product, a single extension, and
                             removes all its services installed by SUSEConnect.
                             After de-registration the system no longer consumes
                             a subscription slot in SCC.
        --instance-data  [path to file]
                             Path to the XML file holding the public key and
                             instance data for cloud registration with SMT.
    -e, --email <email>      Email address for product registration.
        --url [URL]          URL of registration server
                             (e.g. https://scc.suse.com).
                             Implies --write-config so that subsequent
                             invocations use the same registration server.
        --namespace [NAMESPACE]
                             Namespace option for use with SMT staging
                             environments.
    -s, --status             Get current system registration status in json
                             format.
        --status-text        Get current system registration status in text
                             format.
        --list-extensions    List all extensions and modules available for
                             installation on this system.
        --write-config       Write options to config file at /etc/SUSEConnect.
        --cleanup            Remove old system credentials and all zypper
                             services installed by SUSEConnect.
        --rollback           Revert the registration state in case of a failed
                             migration.

Common options:
        --root [PATH]        Path to the root folder, uses the same parameter
                             for zypper.
        --version            Print program version.
        --debug              Provide debug output.
    -h, --help               Show this message.


options like --clean and --list or -l only worked due to the way Ruby parses option, but they weren't officially supported or documented. For -l (reported in https://bugzilla.suse.com/show_bug.cgi?id=1195006) I agree that this would be a sensible decision to add, but in regards to --clean I advise to adjust the test cases to use the documented --cleanup.

To avoid that user run into any kind of trouble, in case they adopted this wrong parameter, we might want to think about documenting this in the Release Notes.

> I advise to adjust the test cases to use the documented --cleanup.

We already adjusted them to use --cleanup, so for automated tests this is not an issue. 

Just in case it is important for customers, this could be fixed. As we discussed with Darragh O'Reilly, the SUSEConnect may allow specific aliases like clean, but not cl, cle, clea etc.

I guess, it is definitely up to Product Management if we need to support the abbreviated flags or just drop this ability from requirements for Go version.

(In reply to Stefan Weiberg from comment #3)
> --clean is not a supported abbreviation of SUSEConnect. 
[...]
> 
> options like --clean and --list or -l only worked due to the way Ruby parses
> option, but they weren't officially supported or documented. For -l
> (reported in https://bugzilla.suse.com/show_bug.cgi?id=1195006) I agree that
> this would be a sensible decision to add, but in regards to --clean I advise
> to adjust the test cases to use the documented --cleanup.
> 
> To avoid that user run into any kind of trouble, in case they adopted this
> wrong parameter, we might want to think about documenting this in the
> Release Notes.

Thanks, I have opened https://bugzilla.suse.com/show_bug.cgi?id=1195106 for Lukas now to mention this in the RN.

Closing, as a separate bug for the RN entry has been opened. Abbreviations for --cleanup and --list-extensions have been added to the upstream project and will be submitted to 15 SP4.