Bug 1202526

I can confirm that Qt6 apps are still looking like Qt apps rather than Gtk-ish ones. Calibre is another example of this.

(In reply to C J from comment #0)
> 2. To get the Gnome theme to apply, I have to do:
> 
> > mkvtoolnix-gui -style adwaita-dark

As I said in the other bug (1202446), can you attach a screenshot of this working please? I'm gonna work on this this week. Thanks for taking the time to file this bug.

Created attachment 861002 [details]
QT6 with adwaita-dark is working

> As I said in the other bug (1202446), can you attach a screenshot of this
> working please?

See the screeshot. I just did:

 > mkvtoolnix-gui -style adwaita-dark

... and the dark them is applied to the QT6 version of the app (look at the system info in the dialog: QT6 6.3.1).

(I am on Gnome).

> I'm gonna work on this this week.

This is awesome. Many thanks.

(In reply to Luciano Santos from comment #1)
> I can confirm that Qt6 apps are still looking like Qt apps rather than
> Gtk-ish ones. Calibre is another example of this.

Here, Calibre is using the default QT dark theme (when Gnome is using the adwaita dark theme).

But mkvtoolnix.qt6 is using the default light theme (when Gnome is using the adwaita dark theme)

(As I said, starting it with "mkvtoolnix-gui -style adwaita-dark" applies the theme properly).

Hmm, that's interesting. Since I'm using openSUSE's GNOME:Next repository (which mostly contains development versions of GNOME packages) I'm gonna do a fresh install in a VM to do some testing before going forward.

Indeed it was the version of GNOME I am at. In a fresh Tumbleweed VM I see the Adwaita theme is applied to the mkvtoolnix-gui window.

I'm gonna test adding Qt6 support to QGnomePlatform to see if the issue get fixed in the GNOME version I'm using daily because if the issue persists it means that GNOME 43 probably will break adwaita-qt and upstream will have to sort things out.

Very well, after adding Qt6 support to the QGnomePlatform package the issue got fixed even in my GNOME 43 alpha/beta system, that's very nice.

Now I'm just gonna forward the fix to the repos and as soon as it gets out in our official download repositories you'll be able to use QT6 apps under GNOME with that juice Gtk-ish look :^P

Created attachment 861208 [details]
MKVToolnix-gui after adding qt6 support to QGnomePlatform

(In reply to Luciano Santos from comment #6)
> Very well, after adding Qt6 support to the QGnomePlatform package the issue
> got fixed even in my GNOME 43 alpha/beta system, that's very nice.
> 
> Now I'm just gonna forward the fix to the repos and as soon as it gets out
> in our official download repositories you'll be able to use QT6 apps under
> GNOME with that juice Gtk-ish look :^P

Nice, it works fine on gnome 43, but now I moved to KDE due to poor 4k hidpi support in gnome and there is a new PROBLEM:

Tested with mkvtoolnix-gui:

1. with KDE scaling at 150% I have to start mkvtoolnix-gui with "QT_SCALE_FACTOR=0.7" otherwise everything is too big.
2. all the icons in the app mkvtoolnix-gui are missing in KDE (it is fine on gnome).

Is this something you can also look into, or should I open a new report with KDE for qt6 apps ?

Thanks.

(In reply to C J from comment #8)
> Tested with mkvtoolnix-gui:
> 
> 1. with KDE scaling at 150% I have to start mkvtoolnix-gui with
> "QT_SCALE_FACTOR=0.7" otherwise everything is too big.
> 2. all the icons in the app mkvtoolnix-gui are missing in KDE (it is fine on
> gnome).

The today TW snapshot fixed these problems with mkvtoolnix.

It's nice to here it's working for you. I believe next week we'll see the changes I did to QGnomePlatform hitting Tumbleweed and the broader community users will get the taste of this fix too.

(In reply to Luciano Santos from comment #10)
> It's nice to here it's working for you.

This was on KDE. On Gnome it still isn't applying the theme.

So, you fixed the qt6 apps (great thanks !), but the qt5 apps sill never had the adwaita theme applied (on gnome qt5 apps have a greyish-greeny theme).

What about that ?

(and on X11 Gnome hidpi (4k) the qt6 and qt5 scaling is completely different. Is there anything you can do about this ?

By default qt6 scaling was fine, but qt5 was too big (when using 150% font scaling in Gnome).

I was able to fix the qt5 scaling by adding these to /etc/environment
> export QT_AUTO_SCREEN_SCALE_FACTOR=0 
> export QT_SCREEN_SCALE_FACTORS=1.5 
> export QT_SCALE_FACTOR=1

But now the qt6 mkvtoolnix has the same problem qt5 apps had before.

So, either qt5 scaling works or qt6, but not both together.

Ayn idea how to fix this ?

Thanks.

(In reply to C J from comment #11)
> (In reply to Luciano Santos from comment #10)
> > It's nice to here it's working for you.
> 
> This was on KDE. On Gnome it still isn't applying the theme.
> 
> So, you fixed the qt6 apps (great thanks !), but the qt5 apps sill never had
> the adwaita theme applied (on gnome qt5 apps have a greyish-greeny theme).
> 
> What about that ?

I'm sorry to hear that, but I have to say I was under the impression, according with you report on https://bugzilla.opensuse.org/show_bug.cgi?id=1202446, that
other Qt apps were fine.

> (and on X11 Gnome hidpi (4k) the qt6 and qt5 scaling is completely
> different. Is there anything you can do about this ?

I'm not sure right now.

> By default qt6 scaling was fine, but qt5 was too big (when using 150% font
> scaling in Gnome).
> 
> I was able to fix the qt5 scaling by adding these to /etc/environment
> > export QT_AUTO_SCREEN_SCALE_FACTOR=0 
> > export QT_SCREEN_SCALE_FACTORS=1.5 
> > export QT_SCALE_FACTOR=1
> 
> But now the qt6 mkvtoolnix has the same problem qt5 apps had before.
> 
> So, either qt5 scaling works or qt6, but not both together.
> 
> Ayn idea how to fix this ?
> 
> Thanks.

Since bugzilla is no place for user support we can use other channels instead, be it using mailing lists be it instant messaging in IRC/Matrix/Discord. There are many people out there in the openSUSE community that may have more accurate answers and maybe know if there's something to be done on our side to help the problem go away or at least mitigate it.

Now, when the changes I made to QGnomePlatform arrive at Tumbleweed we can have another look how Qt 5 and 6 apps will behave for you. Maybe this scaling issue could be some kind of limitation Adwaita-qt has or whatever, for now I can't say much. I don't want to start chasing bugs just yet.

Then if the issue(s) still persist(s) (Adwaita not applying for Qt 5 apps and/or the scaling mess), even with the new changes of QGnomePlatform, you can open a new bug targeting that/those issue(s) and please CC me, OK?!

(In reply to Luciano Santos from comment #12)
> I'm sorry to hear that, but I have to say I was under the impression,
> according with you report on
> https://bugzilla.opensuse.org/show_bug.cgi?id=1202446, that
> other Qt apps were fine.

QT5 apps have always been using the QT5 dark theme instead of adwaita (but this was ok for me as they switched to a dark theme).

But yes, as you fixed it I think using the same theme across the board is the better way.

> Then if the issue(s) still persist(s) (Adwaita not applying for Qt 5 apps
> and/or the scaling mess), even with the new changes of QGnomePlatform, you
> can open a new bug targeting that/those issue(s) and please CC me, OK?!

Ok, FYI the QT5 scaling problems are being fixed here (fix is included):
https://bugzilla.opensuse.org/show_bug.cgi?id=1202837#c12
and
https://bugzilla.opensuse.org/show_bug.cgi?id=1202837#c14

(In reply to C J from comment #13)
> QT5 apps have always been using the QT5 dark theme instead of adwaita (but
> this was ok for me as they switched to a dark theme).

I believe that this will get fixed once QGnomePlatform 0.9.0 [1] and adwaita-qt 1.4.2 [2] lands on Tumbleweed.

> Ok, FYI the QT5 scaling problems are being fixed here (fix is included):
> https://bugzilla.opensuse.org/show_bug.cgi?id=1202837#c12
> and
> https://bugzilla.opensuse.org/show_bug.cgi?id=1202837#c14

I've read the entire bug to know what I'm messing with, and I don't see any fixes there that QGnomePlatform/adwaita-qt should adopt.

The use of QT_SCALE_FACTOR_ROUNDING_POLICY=PassThrough is a last resort for users to try make things right because generally speaking there's no one size fits all. Among the myriad of hardware specs there's always someone who will run into issues.

And here I quote Atri B., who donated his time looking through the problem:

> Therefore, this is not a GNOME bug, re-assigning to YaST devs.
> 
> At the app level, the PassThrough option may be set using `setHighDpiScaleFactorRoundingPolicy()`, see
> <https://doc.qt.io/qt-5/qguiapplication.html#setHighDpiScaleFactorRoundingPolicy>.
> ...
> I think the right way to go about this is to report scaling problems with other apps to the respective upstream and request them to use the passthrough setting or just plain switch to Qt6.

And which I agree, it's not a Gnome bug, "setHighDpiScaleFactorRoundingPolicy()" should be used by the Qt app developers themselves using Qt 5 to get a more uniform experience since Qt 6 set "PassThrough" already rather than "Round". This is not something QGnomePlatform/adwaita-qt should mess with.

Again, let's use other channels to keep such discussions rather than spamming here please.



[1] https://github.com/FedoraQt/QGnomePlatform/releases/tag/0.9.0
[2] https://github.com/FedoraQt/adwaita-qt/releases/tag/1.4.2

(In reply to Luciano Santos from comment #12)
> Now, when the changes I made to QGnomePlatform arrive at Tumbleweed we can
> have another look how Qt 5 and 6 apps will behave for you.

It has finally landed with snapshot 20220929. Thanks !

2 issues:

1. qt5 apps still don't use the gnome dark color theme (they use greenish-grey, gnome is brown (on a properly calibrated screen, when not calibrated it can look grey)).

2. Qt6 apps now use the gnome theme colors (on mkvtoolnix (qt6) it isn't perfect as it seems to use only one color tone, but on Fedora 5 month ago the qt5 version was using the different colors tones to draw the different window sections correctly in different tones).

Many thanks.

1 more thing:

It at first didn't work for qt6 apps. I had to manually go search for and install QGnomePlatform-qt6 (this is a new TW Gnome install from 1 week ago).

I hope new installs now get this by default.

Thanks.

Of course it's still not working for new installs, and that's because the changes I did still haven't landed on Tumbleweed.

I made some rather drastic changes in the package so we let it stay for a while in the Gnome devel projects for some testing. Then before it landed on Factory (where it will then get tested by openQA and if all goes well it lands on Tumbleweed) there were new releases for both Adwaita-qt and QGnomePlatform. All of this made the process take a little longer.

But this Friday's TW snapshot 20220929 we got Adwaita-qt 1.4.2 [1] so on this weekend we probably should get QGnomePlatform 0.9.0 which includes the changes I did (QGnomePlatform-qt6) and a bot will add a comment in this bug referencing the update.


[1] https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/thread/XIGJUF36OHKJWNPYEPOHQHBLR2CMWMHF/

(In reply to Luciano Santos from comment #17)
> But this Friday's TW snapshot 20220929 we got Adwaita-qt 1.4.2 [1] so on
> this weekend we probably should get QGnomePlatform 0.9.0 which includes the
> changes I did (QGnomePlatform-qt6) and a bot will add a comment in this bug
> referencing the update.
> 
> 
> [1]
> https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/thread/
> XIGJUF36OHKJWNPYEPOHQHBLR2CMWMHF/

FYI this status seems wrong, because I just checked again, and with snapshot 20220929 I also got QGnomePlatform 0.9.0 (and it is installed from the TW OSS repo).

Created attachment 861903 [details]
hplip dark theme bug on Gnome

Created attachment 861904 [details]
GOG games installer dark theme bug on Gnome

Added 2 new screenshots with another QT dark theme bug on Gnome:

1. hplip settings (can't read the text and button labels)
2. GOG games installer (same problem)

(this is QT but not QT6, is this also something you can handle here or do you prefer me to open another bug report?)

Thanks.

(In reply to C J from comment #18)
> FYI this status seems wrong, because I just checked again, and with snapshot
> 20220929 I also got QGnomePlatform 0.9.0 (and it is installed from the TW
> OSS repo).

Are you sure it's coming from OSS? I highly doubt that since QGnomePlatform 0.9.0 depends on Adwaita-qt 1.4.2.

(In reply to C J from comment #20)
> Created attachment 861904 [details]
> GOG games installer dark theme bug on Gnome
> 
> Added 2 new screenshots with another QT dark theme bug on Gnome:
> 
> 1. hplip settings (can't read the text and button labels)
> 2. GOG games installer (same problem)
> 
> (this is QT but not QT6, is this also something you can handle here or do
> you prefer me to open another bug report?)
> 
> Thanks.

No, no. This bug is called "QT6 apps don't get Adwaita styling applied under GNOME" and that's exactly what we are trying to fix here. Nothing more, nothing less. Open a new bug - if there isn't one already opened - for that issue.

(In reply to Luciano Santos from comment #21)
> Are you sure it's coming from OSS? I highly doubt that since QGnomePlatform
> 0.9.0 depends on Adwaita-qt 1.4.2.

Yes, both QGnomePlatform (qt5+qt6) 0.9.0-1.2 and adwaita (qt5+qt6) 1.4.2-1.1 from OSS, for at least a week already.

> No, no...Open a new bug

Ok.

Filed Bug 1204021 if you want to look into it further. Thanks.

(In reply to C J from comment #15)

> 2. Qt6 apps now use the gnome theme colors (on mkvtoolnix (qt6) it isn't
> perfect as it seems to use only one color tone, but on Fedora 5 month ago
> the qt5 version was using the different colors tones to draw the different
> window sections correctly in different tones).

This now seems fixed. I don't know if it was the qt 6.4 update (I think ?), but the dark theme colors now are all there in mkvtoolnix 71.1.

This now only leaves the other problem:

> qt5 apps don't use the gnome dark theme (they use the qt dark theme). (but
> qt6 apps correctly use the gnome dark theme).

Thanks.

Alright, thanks for all the feedback here. You can disregard my comment stating we'd se a bot commenting here when the updates would land on Tumbleweed repositories, they seem to happen only for maintenance updates for openSUSE/SUSE stable releases.

I'm closing this bug since our job here is done, both Adwaita-qt 1.4.2 and QGnomePlatform 0.9.0 are already one Tumbleweed (and it looks like QGnomePlatform didn't get an entry in the Tumbleweed snapshot changes log, which is weird for me BTW) and they carry out the fixes for this bug.

Since you are still seeing problems with Qt 5 apps, again, I suggest filing a new bug for this specific issue.

Reopening because this problem is back after updating to snapshot 20221016 (or perhaps was it 20221015):

(In reply to C J from comment #24)
> (In reply to C J from comment #15)
> 
> > 2. Qt6 apps now use the gnome theme colors (on mkvtoolnix (qt6) it isn't
> > perfect as it seems to use only one color tone, but on Fedora 5 month ago
> > the qt5 version was using the different colors tones to draw the different
> > window sections correctly in different tones).
> 
> This now seems fixed. I don't know if it was the qt 6.4 update (I think ?),
> but the dark theme colors now are all there in mkvtoolnix 71.1.

The mkvtoolnix 71.1 dark theme is now back to missing the darker color tone again (The app sections are now all brown in a single color tone).

I don't know which package is causing this?

(In reply to C J from comment #26)

> The mkvtoolnix 71.1 dark theme is now back to missing the darker color tone
> again (The app sections are now all brown in a single color tone).
> 
> I don't know which package is causing this?

Perhaps these 2 problems are linked/have the same cause as they both happened with snapshot 20221016 or 20221015: Bug 1204434 ("export QT_SCALE_FACTOR_ROUNDING_POLICY=PassThrough" in /etc/environment doesn't have any effect anymore, but passing this variable when starting an app in gnome-terminal works).

Today's update (with adwaita-qt6, qgnomeplatform, etc...) fixed it.

Closing again.

Reopening as this issued now came back after today update (11.16, so I guess it's snapshot 11.15).

It looks like one package is causing this every time it is updated (?).

> The mkvtoolnix 71.1 dark theme is now back to missing the darker color tone
> again (The app sections are now all brown in a single color tone).
> 
> I don't know which package is causing this?

If this is really some package causing trouble, we have to pin point this bad boy. I can't do much for a while, since my Linux laptop is facing technical difficulties.

Can you attach a screenshot of how the app looks like when this issue comes back? Is it only mkvtoolnix or other QT6 apps present the same behavior?

Created attachment 862961 [details]
Theme BUG missing darker colors.

Created attachment 862962 [details]
Theme when it works correctly.

(In reply to Luciano Santos from comment #30)
> Can you attach a screenshot of how the app looks like when this issue comes
> back?

Done, see above.

> Is it only mkvtoolnix or other QT6 apps present the same behavior?

I think mkvtoolnix is the only qt6 app I am using, so I don't know.

Thanks.

(In reply to C J from comment #32)
> Created attachment 862962 [details]
> Theme when it works correctly.

Some more info:
Just too this shot from archlinux to show how it also looks on opensuse when it works (it's exactly the same).

Correction:

(In reply to C J from comment #29)
> Reopening as this issued now came back after today update (11.16, so I guess
> it's snapshot 11.15).

The snapshot that reintroduced the bug is 20221114-0.

(In reply to C J from comment #33)
> (In reply to Luciano Santos from comment #30)
> I think mkvtoolnix is the only qt6 app I am using, so I don't know.

It would be really nice to know whether other QT 6 apps present the same issue or only mkvtoolnix. Chances are it's all of them, but still there's a small chance it isn't.

(In reply to C J from comment #35)
> Correction:
> 
> (In reply to C J from comment #29)
> > Reopening as this issued now came back after today update (11.16, so I guess
> > it's snapshot 11.15).
> 
> The snapshot that reintroduced the bug is 20221114-0.

It seems unlikely that was 20221114 [1], it only brought three package updates:

> grub2
> libnma
> sed

[1] http://download.opensuse.org/tumbleweed/iso/Changes.20221114.txt

(In reply to Luciano Santos from comment #36)
> It seems unlikely that was 20221114 [1], it only brought three package
> updates:

Ah yes, that's why I first thought that it was 20221115-0 as I updated on 11.16, but today it updated from 20221114-0 to 20221115-0.

So the culprit is probably 20221112 or 20221113.

Fixed again with today's snapshot 20221122.

The same problem appeared again a few days ago after the qgnomeplatform updates.

So, it looks like every time this is updated the problem comes back.

Hi, what's your qtbase version? Did you meet this upstream issue? <https://github.com/FedoraQt/QGnomePlatform/issues/124>

(In reply to Alynx Zhou from comment #40)

I'm not sure it's the same issue, as in your link the theme isn't applied at all. Here, the theme is applied but the dark colors are missing (see screenshot).

But: this was now fixed again after an update (it seems to break every 1 or 2 months and then is fixed again, so I have reopened and closed this bug several times already).

-> closing again, (hope this time its definitive).

That issue makes sense, though. Some package, other than QGnomePlatform and Adwaita-qt6, is not respecting the theme applied by Adwaita-qt, so whenever it gets updated it messes the theme that should be applied. And when QGnomePlatform gets updated the problem gets fixed.