Bug 1203302

Summary:	YaST2 package downloader shows negative remaining
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Christopher Yeleighton <giecrilj>
Component:	YaST2	Assignee:	Forgotten User kWxJsf0s20 <forgotten_kWxJsf0s20>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P5 - None
Version:	Current
Target Milestone:	---
Hardware:	x86-64
OS:	openSUSE Tumbleweed
Whiteboard:
Found By:	Community User	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Christopher Yeleighton 2022-09-10 09:00:57 UTC

1. Connect to a commuted, captivated and time-limited slow Internet connection!
2. Tell the software manager to install lots of packages (much more than session capacity)!
3. Whenever the downloader reports a wrong package checksum (which happens each time when a session has expired), reopen a session and tell the downloader to retry!

When the downloader has downloaded most packages, the amount remaining to be downloaded is displayed as a negative number.

Comment 1 Michal Filka 2022-09-12 07:39:17 UTC

I'd say that the most of enterprise won't meet such problem. So, it clearly is an issue which might happen in wider community. Then it sounds fair to keep it up to community whether invest an effort in such edge muse case (huge package download over weak line).

Comment 2 Christopher Yeleighton 2022-09-14 11:32:38 UTC

Slide show call-back [Done package] does not update the total if the result of the package call-back is "RETRY".  It should not when it is "CANCEL" either.
I am not a Ruby guy, it would be better if someone else fixed it.
Source: SlideShowCallbacks.rb:454

Comment 3 Christopher Yeleighton 2022-09-14 11:48:09 UTC

(In reply to Michal Filka from comment #1)
> I'd say that the most of enterprise won't meet such problem. So, it clearly
> is an issue which might happen in wider community. Then it sounds fair to
> keep it up to community whether invest an effort in such edge muse case
> (huge package download over weak line).

The case is that the package check sum is unexpected.  It may be the case of a broken package or a MiM attack (a captive portal is a beningn case of a MiM attack).  These things can happen in an enterprise environment, especially using custom repositories.

Comment 4 Christopher Yeleighton 2022-09-16 12:00:54 UTC

I have created <URL: https://github.com/yast/yast-packager/pull/623 >

Comment 5 Stefan Hundhammer 2022-12-14 10:34:37 UTC

Thanks for your fix!

It's now merged, and there is a follow-up PR for the version bump and the change log: 

https://github.com/yast/yast-packager/pull/629

The fixed version will become available with yast2-packager-4.5.9.