Bug 1205402

Summary: Network gets reloaded in yast2_lan_restart_bridge test even without changes in configuration
Product: [openSUSE] PUBLIC SUSE Linux Enterprise Server 15 SP5 Reporter: Rainer König <rainer.konig>
Component: YaST2Assignee: E-mail List <yast2-maintainers>
Status: RESOLVED INVALID QA Contact:
Severity: Normal    
Priority: P2 - High CC: rainer.konig
Version: unspecified   
Target Milestone: ---   
Hardware: Other   
OS: Other   
URL: https://openqa.suse.de/tests/9952363/modules/yast2_lan_restart_bridge/steps/62
Whiteboard:
Found By: openQA Services Priority:
Business Priority: Blocker: Yes
Marketing QA Status: --- IT Deployment: ---

Description Rainer König 2022-11-14 14:31:31 UTC 
## Observation

Wicked reloads network, even if the test says that a reload is not necessary because nothing changed. 


openQA test in scenario sle-15-SP5-Online-x86_64-yast2_gui@rakoenig/os-autoinst-distri-opensuse#fix_screen_refresh@64bit fails in
[yast2_lan_restart_bridge](https://openqa.suse.de/tests/9952363/modules/yast2_lan_restart_bridge/steps/62)

## Test suite description
Maintainer: zluo, riafarov

Test for yast2 UI, GUI only. Running on created gnome images which provides both text console for ncurses UI tests as well as the gnome environment for the GUI tests.


## Reproducible

Fails since (at least) Build [rakoenig_fix_screen_refresh](https://openqa.suse.de/tests/9806913)



## Further details

* This problem was found during a verification run for the fix for another problem. Without that fix for the other problem the test fails much before it checks for this problem, so it is probably not yet discovered in the official YaST build review. 

* This problem probably describes the same problem as https://bugzilla.suse.com/show_bug.cgi?id=1185775 (which I cannot access for unknown reasons).
Comment 1 Stefan Hundhammer 2022-11-16 12:03:33 UTC 
Does this test use the "Next" button to get out of the YaST network module?

In that case, it might happen that network settings are applied even though there was no real change. In some scenarios, this might even be desired; for example when a user wishes to restart the network (in case of unknown networking problems).

If you know there was no change, and you want to leave a YaST module without restarting anything, please use the "Cancel" button.
Comment 2 Stefan Hundhammer 2022-11-16 12:07:20 UTC 
Please notice that this is a general usage pattern in YaST modules. Not in all cases it's 100% clear if there really were any changes; that would mean keeping exact track of every bit that the user may have changed, and that is not always possible.

If there is any doubt about that, some (many?) YaST modules choose to apply the settings to be on the safe side. There should also be no harm done.
Comment 3 Rainer König 2022-11-16 13:02:38 UTC 
just looked at the code and yes, the test module issues a click on the "Next" button. Let me disuss this in our team, probably we need to change the test code.
Comment 4 Stefan Hundhammer 2022-12-07 14:29:40 UTC 
OK, then it behaves as expected. Closing.