|
Bugzilla – Full Text Bug Listing |
| Summary: | Rust 1.67 breaks rusticl build in Mesa:drivers (rust upstream fix available in git) | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE Tumbleweed | Reporter: | Dominique Leuenberger <dimstar> |
| Component: | Other | Assignee: | William Brown <william.brown> |
| Status: | RESOLVED FIXED | QA Contact: | E-mail List <qa-bugs> |
| Severity: | Normal | ||
| Priority: | P5 - None | CC: | sndirsch |
| Version: | Current | ||
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
|
Description
Dominique Leuenberger
2023-02-06 10:51:18 UTC
Possibly related to https://github.com/rust-lang/rust/issues/107334 Hmm. How am I supposed to reproduce that issue? I was trying by running osc build -M drivers --alternative-project openSUSE:Factory:Staging:G standard After this succeeded I noticed that there is still rust 1.66 installed in the buildsystem. Not knowing anything about rust could I use BuildRequires: rust = 1.66 BuildRequires: rust-bindgen (In reply to Stefan Dirsch from comment #2) > Hmm. How am I supposed to reproduce that issue? I was trying by running > > osc build -M drivers --alternative-project openSUSE:Factory:Staging:G > standard It's in Staging:L - not :G > After this succeeded I noticed that there is still rust 1.66 installed in > the buildsystem. According to comment#1 this seems more likely to be a rust regression which I don't think we should just work around by picking Rust 1.66 to avoid it. It should be fixed in Rust > It's in Staging:L - not :G Ok. I didnt't read the comments in SR to the end. :-( > According to comment#1 this seems more likely to be a rust regression which I don't think we should just work around by picking Rust > 1.66 to avoid it. It should be fixed in Rust Well, I still don't understand when this issue was really fixed. According to git with # git show 252741673b9c2b06267cd3a036d77489e92f963a commit 252741673b9c2b06267cd3a036d77489e92f963a Merge: 6cd6bad51fb de363d54c40 Author: bors <bors@rust-lang.org> Date: Sat Jan 28 04:02:25 2023 +0000 Auto merge of #107360 - bjorn3:fix_thin_archive_reading, r=wesleywiser Fix thin archive reading This includes a revert of https://github.com/rust-lang/rust/pull/105221 to restore fat archive reading with LlvmArchiveBuilder. Should fix #107162, #107334 and https://github.com/google/shaderc-rs/issues/133 # git describe 252741673b9c2b06267cd3a036d77489e92f963a 1.0.0-beta-175357-g252741673b9 So long before 1.67 and even 1.66. OTOH this is just 9 days ago ... References: https://github.com/rust-lang/rust/issues/107334 https://github.com/rust-lang/rust/pull/107360 https://gitlab.freedesktop.org/mesa/mesa/-/issues/8172 [...] That is a known regression [1] in rust, which is already fixed upstream[2] and likely will soon make it to the point release. [1] https://github.com/rust-lang/rust/issues/107334 [2] https://github.com/rust-lang/rust/pull/107360 Reassigning ... Okay, I guess we just have to wait on a .1 release then ... (In reply to William Brown from comment #8) > Okay, I guess we just have to wait on a .1 release then ... I guess so, if this is what they mean with a 'point release'. If we need to update urgently please let me know. I think it's possible to temporarily buildrequire rust 1.66 by Mesa (IIRC; untested though). But we then need to track this, so I won't forget to go back to buildrequire rust without version number. IIRC --> IIUC (In reply to Stefan Dirsch from comment #9) > (In reply to William Brown from comment #8) > > Okay, I guess we just have to wait on a .1 release then ... > > I guess so, if this is what they mean with a 'point release'. Yep, that's what I mean. > > If we need to update urgently please let me know. I think it's possible to > temporarily buildrequire rust 1.66 by Mesa (IIRC; untested though). But we > then need to track this, so I won't forget to go back to buildrequire rust > without version number. Really it comes down to two options: * Delay the upgrade to 1.67.0 and release it for everyone when 1.67.1 is out. * Set Mesa to 1.66, so we can release 1.67.0 for everyone else to use, and then undo the build-requires when 1.67.1 is out. I'm just not sure when 1.67.1 will release, I've subscribed to the various github threads, and I'm waiting on it ... Thanks. I agree. 3rd option would be to add the required patches to fix the issue. But I'm afraid cherry-picking them isn't trivial. Also they may need additional patches before you can apply them ... Seems like upstream rust are already drafting a release for 1.67.1 so hopefully it'll be out soon :) Seems rust 1.67.1 has been released, so can we close this now as fixed. SUSE-RU-2023:0630-1: An update that has one recommended fix can now be installed. Category: recommended (moderate) Bug References: 1207928 Sources used: openSUSE Leap 15.4 (src): rust-1.67.1-150400.24.9.1 Development Tools Module 15-SP4 (src): rust-1.67.1-150400.24.9.1 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination. So let's assume this issue is fixed now with current rust 1.67.1. |