Bug 179019

Summary:	Security problem: Can't disable SMB/NFS share on a folder under Konqueror after enabled it
Product:	[openSUSE] openSUSE 10.2	Reporter:	Sebastien ROHAUT <sebastien.rohaut>
Component:	KDE	Assignee:	E-mail List <kde-maintainers>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Major
Priority:	P1 - Urgent	CC:	security-team, suse-beta
Version:	Alpha 1
Target Milestone:	---
Hardware:	i686
OS:	SuSE Linux 10.1
Whiteboard:
Found By:	Customer	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	kdelibs3 patch

Description Sebastien ROHAUT 2006-05-26 07:44:56 UTC

Hi, 

i found a security problem with file sharing under KDE :

I authorized users to share their folders using SMB/NFS sharing under KDE with Konqueror. For this I go in Personal Settings->Internet&Network->File Sharing (fileshare kcm module), "Enable Local Netwok File Sharing", "Simple Sharing", allowed users : Allow all users to share folders.

Then I open Konqueror, right click on a folder and click on "Share" (or on Properties->Share). I click on "Shared" radio button and OK. My folder is shared, I can see it from another computer as smb share.

Now I wan't to disable sharing. I return to "Share" and there are two problems :
- "Not shared" is activated by defaut event if the folder is already shared.
- If I choose this default action and click OK, my folder remains shared.

I think this is a security problem : users can't remove their SMB shares from Konqueror. So everybody can access them even if the user tries to disable them. Only root can go to kcm fileshare module and remove a share.

So I put severity as critical.

I hope this bug will be corrected soon.

Comment 1 Sebastien ROHAUT 2006-05-26 20:17:20 UTC

This problem doesn't occur when Advanced Sharing is enabled...

Comment 2 Lubos Lunak 2006-06-09 15:22:57 UTC

Created attachment 88348 [details]
kdelibs3 patch

Our filesharelist has incompatible output to the KDE's one, but the matching kdelibs patch (fileshare.diff) is disabled, because it doesn't apply (and it also contains some i18n that is not in kdebase-SUSE/totranslate).

This filesharesimple.diff patch is the small subset of the patch that parses out output. With it this problem goes away.

Comment 3 Dirk Mueller 2006-06-14 19:13:18 UTC

ok, I added this minimal patch for 10.1, rehubbing for 10.2.

Comment 4 Sebastien ROHAUT 2006-06-14 19:27:08 UTC

Ok. Will this patch applied to 3.5.3 branch (I upgraded from lastest KDE3 repository) ?

Comment 5 Thomas Biege 2007-05-21 12:30:09 UTC

Ok, I think the bug is fixed now.