Bug 192535

Created attachment 93602 [details]
YaST2.tar.bz2

yast2 logfiles.

I tried it twice... First install with regular logging.

Then second with ZYPP_FULLLOG=1 and reselect patch.

Created attachment 93605 [details]
zypp-xmlstore-do-script-zgBkw4

script it tries to run.

in /var/tmp/ are these scripts (from my current runs).

zypp-xmlstore-do-script-F9UG8D
zypp-xmlstore-do-script-Gj3yI0
zypp-xmlstore-do-script-ooDQP2
zypp-xmlstore-do-script-zgBkw4
zypp-xmlstore-undo-script-0Gt3Z1
zypp-xmlstore-undo-script-lfDUbh
zypp-xmlstore-undo-script-RlwIAt
zypp-xmlstore-undo-script-ZTNCwv


Note that in the logfile it calls a script which is not there?

err,

actually it only calls the "undo" script, but nevert the "do" script!

rpm -q libzypp ?

libzypp-1.2.0-1.23

testsystem is still live on westernhagen.suse.de if you want to take a look.

any update?

blocking next libzypp update

Sorry, I was in Boston. Found the reason. Will commit soon.

Ok,  have a fix. The released SLES also suffers from this, so a update will be needed there.
I will need some help testing it.
I have a build on  /work/built/mbuild/piscola-dmacvicar-8 so it can be tested on SLES as well as in 10.1.

fix in rev 3845
package in /work/built/mbuild/piscola-dmacvicar-8

Sorry, I built aganst stable.
for SLES10: /work/built/mbuild/piscola-dmacvicar-12
for 10.1 /work/built/mbuild/piscola-dmacvicar-11

does not seem to be in current 10.1 checkin.

so it is not fixed.

Created attachment 96389 [details]
yast2logs.tar.bz2

new logfiles

Now seems totally unrelated. The problem before the fix, was the handling of temp files was broken. Now, that is fixed. And the current problem is totally unrelated, and even expected.

Well, the patch in the solver appears as satisfied, so it was run before. So the solver wont run it again. Probably by an old patch with the same script version.

US_s_[S3:0][script]fetchmsttfonts.sh-patch-fetchmsttfonts.sh-2-1322-1.noarch

US_s_ is (U)ninstalled, (S)atisfied.

Actually, there are two versions of this patch, -1322- and -1829-

Marcus, please run with "ZYPP_FULLLOG=1". It looks like one is already installed.
Schubi might have a look on this also.

The logfiles does not show installed patches at all ( with the exception of installed patches which are triggered for uninstall). 
The fetchmsttfonts.sh-1829 patch ( in the source ) is already satified and has been selected by the user for installation.

The solver returns:
USTu_[S3:0][patch]fetchmsttfonts.sh-1829-0.noarch    // satified and selected by the user
US_s_[S3:0][script]fetchmsttfonts.sh-patch-fetchmsttfonts.sh-2-1322-1.noarch
US_s_[S3:0][message]fetchmsttfonts.sh-patch-message-1-1322-1.noarch
US_s_[S3:0][patch]fetchmsttfonts.sh-1322-0.noarch
US_s_[S3:0][script]fetchmsttfonts.sh-patch-fetchmsttfonts.sh-2-1829-1.noarch

The scripts will not be selected for installation again, cause they are satified which means that they have been already installed.

Duncan, could you please check the DB if the patch has already been installed ?

Markus, you have not only used you.suse.de:

2006-08-18 12:27:18 <0> westernhagen(4768) [zypp::SourceManager] SourceManager.cc(restore):464 SourceManager: =========================
2006-08-18 12:27:18 <0> westernhagen(4768) [zypp::SourceManager] SourceManager.cc(restore):464   known Sources 3
2006-08-18 12:27:18 <0> westernhagen(4768) [zypp::SourceManager] SourceManager.cc(restore):464     - Source[1|YaST|SUSE-Linux-10.1-DVD9-x86-x86_64-10.1-0-20060817-175650]{ftp://10.10.0.100/install/SLP/SUSE-10.1-DVD9-RC5/x86_64/DVD1(/); cache /var/lib/zypp/cache/Source.rh1we4}
2006-08-18 12:27:18 <0> westernhagen(4768) [zypp::SourceManager] SourceManager.cc(restore):464     - Source[2|YUM|20060818-101045]{http://ftp.leo.org/pub/comp/os/unix/linux/suse/suse/update/10.1(/); cache /var/lib/zypp/cache/Source.Nb0tWJ}
2006-08-18 12:27:18 <0> westernhagen(4768) [zypp::SourceManager] SourceManager.cc(restore):464     - Source[3|YUM|20060818-115935]{ftp://you.suse.de/%2Fpub/suse/update/10.1(/); cache /var/lib/zypp/cache/Source.C2QeL8}
2006-08-18 12:27:18 <0> westernhagen(4768) [zypp::SourceManager] SourceManager.cc(restore):464   deleted Sources 0
2006-08-18 12:27:18 <0> westernhagen(4768) [zypp::SourceManager] SourceManager.cc(restore):464 ========================================

Additional: I cannot find the patch fetchmsttfonts.sh-1322-0 on you.suse.de, although it should be available in S3:
US_s_[S3:0][patch]fetchmsttfonts.sh-1322-0.noarch

I will leave this system live (westernhagen.suse.de) for you to test today.

I am believe that is the solver. 

The patch requires the script. The script is satisfied. So it will not be triggered for installation. I have changed it in "isPresent":
--- ResolverContext.cc  (Revision 3783)
+++ ResolverContext.cc  (Arbeitskopie)
@@ -632,8 +632,12 @@
 
     bool res = ((status.staysInstalled() && !status.isIncomplete())
                || (status.isToBeInstalled() && !status.isNeeded())
-               || status.isUnneeded()
-               || status.isSatisfied());
+               || ((status.isUnneeded() || status.isSatisfied())
+                   // regarding only resolvables where the status is useful Bug:192535
+                   && item->kind() != ResTraits<Package>::kind
+                   && item->kind() != ResTraits<Script>::kind
+                   && item->kind() != ResTraits<Message>::kind)
+               );
 
    if (unneeded) *unneeded = status.isUnneeded();

Klaus, I am not really happy with this fix. Are there other possibilities ?

Klaus was not in CC ;)

Klaus?

(as discussed with Stefan this morning)

Fix looks ok. But we need a testcase to verify.
Needinfo to Stefan now.

btw, i tested the fixed libzypp and it run the script now...

hmm.

there is fallout.

the "postgresq-server-1442" patch is now shown all the time, but does
not install packages.

I do not have postgresql-server the package installed.

I suspect this has something to do with the "message" within the patchfile.

I have fixed and have added a testcase for installation scripts:
patch-tests/script-test.xml

Message test follows...

Fixed and submitted to 10.1
Revision 4142

released

*** Bug 224401 has been marked as a duplicate of this bug. ***