Bug 194389

Summary: YaST2 xen Module Bug in X Detection
Product: [openSUSE] SUSE Linux 10.1 Reporter: Forgotten User wbt-beX79k <forgotten_wbt-beX79k>
Component: YaST2Assignee: Forgotten User giyd7i7t_J <forgotten_giyd7i7t_J>
Status: RESOLVED FIXED QA Contact: Stanislav Visnovsky <visnov>
Severity: Major    
Priority: P1 - Urgent CC: suse-beta
Version: Final   
Target Milestone: ---   
Hardware: x86-64   
OS: SLES 10   
Whiteboard:
Found By: Third Party Developer/Partner Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Forgotten User wbt-beX79k 2006-07-23 06:42:20 UTC
A check was commited to the xen yast module to make sure that an x server was available that is suboptimal as it requires having an installed x server when one isn't needed.  It's entirely possible to setup everything remotely via an ssh connection with x forwarding and have the yast module check for the DISPLAY environment variable instead of the presence of xdpyinfo like it currently does:

+// check whether X window system is accessible
+integer exit_status = (integer) SCR::Execute(.target.bash, "/usr/X11R6/bin/xdpyinfo");
+y2milestone("X check exit status: %1", exit_status);
+
+if (exit_status != 0)
+{
+    // error - the installation runs in xterm, we need access to a X server
+    Report::Error(_("Virtual machine installation requires access to a graphical environment."));
+
+    return `abort;
+}
+

I found this commit at http://lists.opensuse.org/archive/opensuse-commit/2006-May/0651.html .  There's no reason that I can find for the need to install an X server just to get xdpyinfo.
Thanks,
Dan
Comment 1 Forgotten User giyd7i7t_J 2006-08-10 18:34:11 UTC
Thanks for the suggestion Dan. :-)

yast2-vm will now check whether the X window system is accessible by testing for the existance of the a non-empty DISPLAY enviroment value.

Fix is checked into yast2-vm-2.13.62