Bug 202351

Summary: NFS Server - Progress bar doesn't have so many steps
Product: [openSUSE] openSUSE 10.2 Reporter: Lukas Ocilka <locilka>
Component: YaST2Assignee: Michal Zugec <mzugec>
Status: RESOLVED WONTFIX QA Contact: Jiri Srain <jsrain>
Severity: Minor    
Priority: P5 - None CC: jsmeix
Version: Alpha 3 plus   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Lukas Ocilka 2006-08-29 07:57:25 UTC
2006-08-28 16:30:06 <1> miracle(26130) [YCP] Service.ycp:388 Enabling service nfsserver
2006-08-28 16:30:07 <1> miracle(26130) [YCP] Service.ycp:453 Stopping service nfsserver
2006-08-28 16:30:07 <1> miracle(26130) [YCP] Service.ycp:279 Running service initscript nfsserver stop
2006-08-28 16:30:07 <1> miracle(26130) [YCP] Service.ycp:411 Starting service nfsserver
2006-08-28 16:30:07 <1> miracle(26130) [YCP] Service.ycp:279 Running service initscript nfsserver start
2006-08-28 16:30:07 <1> miracle(26130) [YCP] SuSEFirewall.ycp:2102 Firewall configuration has been changed. Writing: $["FW_ALLOW_FW_BROADCAST_DMZ":"no", "FW_ALLOW_FW_BROADCAST_EXT":"8765", "FW_ALLOW_
FW_BROADCAST_INT":"no", "FW_DEV_DMZ":"", "FW_DEV_EXT":"any eth-bus-pci-0000:05:0c.0", "FW_DEV_INT":"", "FW_FORWARD_ALWAYS_INOUT_DEV":"", "FW_FORWARD_MASQ":"", "FW_IGNORE_FW_BROADCAST_DMZ":"no", "FW_I
GNORE_FW_BROADCAST_EXT":"yes", "FW_IGNORE_FW_BROADCAST_INT":"no", "FW_IPSEC_TRUST":"no", "FW_LOG_ACCEPT_ALL":"no", "FW_LOG_ACCEPT_CRIT":"yes", "FW_LOG_DROP_ALL":"no", "FW_LOG_DROP_CRIT":"yes", "FW_MA
SQUERADE":"no", "FW_PROTECT_FROM_INT":"no", "FW_ROUTE":"no", "FW_SERVICES_ACCEPT_DMZ":"", "FW_SERVICES_ACCEPT_EXT":"80.44.11.22/32,tcp,53 80.44.11.0/255.255.255.0,tcp,53 10.20.0.0/24,tcp,22 10.20.1.0
/24,tcp,domain 10.20.1.0/24,udp,domain 10.20.1.50,tcp,80:100,8080 80.55.55.55,_rpc_,portmap 10.20.0.0/255.255.248.0,udp,,427", "FW_SERVICES_ACCEPT_INT":"80.44.11.22,_rpc_,portmap", "FW_SERVICES_DMZ_I
P":"", "FW_SERVICES_DMZ_RPC":"", "FW_SERVICES_DMZ_TCP":"", "FW_SERVICES_DMZ_UDP":"", "FW_SERVICES_EXT_IP":"", "FW_SERVICES_EXT_RPC":"mountd nfs nfs_acl nlockmgr portmap status", "FW_SERVICES_EXT_TCP"
:"10245 5801 5901 domain ssh", "FW_SERVICES_EXT_UDP":"8765 domain", "FW_SERVICES_INT_IP":"", "FW_SERVICES_INT_RPC":"", "FW_SERVICES_INT_TCP":"", "FW_SERVICES_INT_UDP":"", "enable_firewall":true, "sta
rt_firewall":false].
2006-08-28 16:30:07 <1> miracle(26130) [YCP] SuSEFirewall.ycp:2119 Enabling firewall services
2006-08-28 16:30:07 <1> miracle(26130) [YCP] Service.ycp:388 Enabling service SuSEfirewall2_init
2006-08-28 16:30:07 <1> miracle(26130) [YCP] Service.ycp:388 Enabling service SuSEfirewall2_setup
2006-08-28 16:30:08 <1> miracle(26130) [YCP] SuSEFirewall.ycp:1154 Firewall services are stopped
2006-08-28 16:30:08 <1> miracle(26130) [YCP] SuSEFirewall.ycp:2057 Firewall has been stopped already
2006-08-28 16:30:08 <3> miracle(26130) [YCP] Progress.ycp:279 Progress bar doesn't have so many steps.


2006-08-28 16:30:08 <3> miracle(26130) [ui] YUI_widgets.cc(widgetWithId):2404 No widget with `id( "bar_label_2" )
2006-08-28 16:30:08 <3> miracle(26130) [libycp] Progress.ycp:317 No widget with `id( "bar_label_2" )


2006-08-28 16:30:08 <1> miracle(26130) [YCP] clients/nfs_server.ycp:300 NFS module finished
2006-08-28 16:30:08 <1> miracle(26130) [YCP] clients/nfs_server.ycp:301 ----------------------------------------
Comment 1 Martin Vidner 2006-09-04 11:12:16 UTC
Yes. This is actually a long standing problem.
Comment 2 Martin Vidner 2006-09-11 08:25:01 UTC
It is because SuSEFirewall::Write*() is called which has its own progress reporting. It should be wrapped like this:
        boolean progress_orig = Progress::set (false);
        SuSEFirewall::Write ();
        Progress::set (progress_orig);

Modules which need the fix:
mvidner: nfs-client nfs-server tftp-server mail
mzugec: http-server. also, iscsi-server wrongly uses Progress::set(true/false)
jsmeix: scanner possibly too, I cannot tell at the 1st glance
Comment 3 Johannes Meixner 2006-09-11 09:36:16 UTC
In yast2-scanner I show the firewall progress intentionally
to have feedback for unexperienced users when the firewall settings
are actually changed because those uses don't know about the good old
Unix style "no news are good news" ;-)
Comment 4 Lukas Ocilka 2006-09-11 10:29:39 UTC
Johannes, that's wrong because it doesn't follow a YaST style. Nobody complains it this (own firewall steps) is missing.

You should rather create _ONE_ step for the entire firewall and handle it by yourself - you never know how many steps the firewall's progress has.
Comment 5 Johannes Meixner 2006-09-11 10:47:58 UTC
There is no higher level progress running when the firewall progress runs.
Therefore it doesn't matter for yast2-scanner how many steps the firewall
progress shows.
But if it is forbidden to show a progress of a subsequent module,
I will simply run it in the good old Unix style.

Comment 6 Johannes Meixner 2006-09-11 13:30:29 UTC
I simply disabled showing Progress from SuSEFirewall::Read
and SuSEFirewall::Write
Comment 7 Martin Vidner 2006-09-11 16:17:08 UTC
I have fixed my modules, over to Miso for HTTP and iSCSI.
Comment 8 Michal Zugec 2007-01-30 10:25:56 UTC
move to later
Comment 9 Stephan Kulow 2008-06-25 09:19:06 UTC
mass reopening all 10.2 LATER+REMIND bugs.
Comment 10 Stephan Kulow 2008-06-25 09:23:13 UTC
close all 10.2 LATER/REMIND bugs as WONTFIX. Reopen yourself if you still plan to work on it.